Changes between Version 17 and Version 18 of Rules/QAToolInspiredValidations

Timestamp:

2019-03-10T16:00:47+01:00 (7 years ago)

Author:

frodrigo

Comment:

Add Osmose mapcss tags

Rules/QAToolInspiredValidations

@@ -9 +9 @@
   watch-modified: true;
   link: "https://wiki.openstreetmap.org/wiki/Osmose/issues";
+  min-josm-version: 14481;  
 }
 
@@ -37 +38 @@
 way[highway=cycleway]!:closed!.connected_node.new_feature >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking],
 way[highway=cycleway]!:closed!.connected_node.new_feature >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking] {
-    throwWarning: tr("1210: Unconnected Cycleway");
-    group: "OSMOSE";
+    throwWarning: tr("Unconnected Cycleway");
+    -osmoseItemClassLevel: "1210/1/1";
+    -osmoseTags: list("highway", "cycleway", "fix:chair");
+    group: "OSMOSE 1210 - not-connected highway/cycleway";
 }
 
@@ -47 +50 @@
 way[highway=~/^(motorway|trunk|primary|secondary|tertiary|unclassified)$/]!:closed!.connected_node.new_feature >[index=-1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking][highway!=turning_circle],
 way[highway=~/^(motorway|trunk|primary|secondary|tertiary|unclassified)$/]!:closed!.connected_node.new_feature >[index=1] node[noexit!=yes][amenity!=parking_entrance][amenity!=parking][highway!=turning_circle] {
-    throwWarning: tr("1210: Unconnected Highway");
-    group: "OSMOSE";
+    throwWarning: tr("Unconnected Highway");
+    -osmoseItemClassLevel: "1210/2/1";
+    -osmoseTags: list("highway", "fix:chair");
+    group: "OSMOSE 1210 - not-connected highway/cycleway";
 }
 
@@ -57 +62 @@
 }
 
-relation[type] >[index=1].member way {
-    throwWarning: tr("1200: One Member Relation; Check for other members");
-    group: "OSMOSE";
+relation[type][type!~/^(defaults|route|route_master|associatedStreet)$/][site!=geodesic] >[index=1].member way {
+    throwWarning: tr("1200: One Member Relation; Check for other members or remove relation");
+    -osmoseItemClassLevel: "1200/12001:1/2";
+    -osmoseTags: list("relation", "fix:chair");
+    group: "OSMOSE 1200 - 1-member relation";
 }
 
  /* Bad link highway -- OSMOSE Item 1110 */ 
 
-/*class 2*/
-way[highway*="_link"][eval(waylength()) > 1000] {
-    throwWarning: tr("1110/2: Bad *_link Highway; highway too long for a *_link");
-    group: "OSMOSE";
+way[highway*="_link"][highway!~/^(motorway_link|trunk_link)$/][eval(waylength()) > 1000] {
+    throwWarning: tr("Highway too long for a *_link");
+    -osmoseItemClassLevel: "1110/2/1";
+    -osmoseTags: list("relation", "fix:chair");
+    group: "OSMOSE 1110 - bad *_link highway";
 }
 
  /* Bridge to tag -- OSMOSE Item 7012 */
-way[bridge=yes][!/^bridge:/][eval(waylength()) > 500] {
-    throwWarning: tr("7012: Bridge to Tag; bridge deserving of more detail");
-    group: "OSMOSE";
+
+way[bridge=yes][highway!~/^(motorway|trunk|primary|secondary)$/][!/^bridge:/][eval(waylength()) > 500],
+way[bridge=yes][railway][!/^bridge:/][eval(waylength()) > 500] {
+    throwInfo: tr("Bridge structure missing");
+    -osmoseItemClassLevel: "7012/1/3";
+    -osmoseTags: list("tag", "highway", "fix:survey");
+    group: "OSMOSE 7012 -  bridge to tag";
 }