Changes between Initial Version and Version 1 of Rules/QAToolInspiredValidations


Ignore:
Timestamp:
2019-01-22T19:45:14+01:00 (7 years ago)
Author:
abalosc1
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • Rules/QAToolInspiredValidations

    v1 v1  
     1{{{
     2#!rule
     3meta
     4{
     5  title: "Osmose Validations";
     6  version: "[[revision]]_[[date]]";
     7  description: "Checks for errors based on Osmose tag checks";
     8  author: "Dave Manzer";
     9  watch-modified: true;
     10  link: "https://wiki.openstreetmap.org/wiki/Osmose/issues";
     11}
     12
     13
     14/* tagwatch cleaner 3030 deprecated Tags --- partially complete*/
     15
     16*[amenity=chapel]{
     17        throwWarning: "{0.tag} is deprecated";
     18    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");     
     19        suggestAlternative: "amenity=place_of_worship, religion=christian";
     20        fixAdd: "amenity=place_of_worship";
     21        fixAdd: "religion=christian";
     22}
     23
     24*[amenity = bakery]{
     25        throwWarning: "{0.tag} is deprecated";
     26    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     27        suggestAlternative: "shop=bakery";
     28        fixAdd: "shop=bakery";
     29        fixRemove: "amenity"
     30}
     31
     32*[amenity = chocolatier]{
     33        throwWarning: "{0.tag} is deprecated";
     34    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     35        suggestAlternative: "shop=chocolatier";
     36        fixAdd: "shop=chocolatier";
     37        fixRemove: "amenity"
     38}
     39
     40*[amenity = dry_cleaning]{
     41        throwWarning: "{0.tag} is deprecated";
     42    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     43        suggestAlternative: "shop=dry_cleaning";
     44        fixAdd: "shop=dry_cleaning";
     45        fixRemove: "amenity"
     46}
     47
     48*[amenity = emergency_phone]{
     49        throwWarning: "{0.tag} is deprecated";
     50    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     51        suggestAlternative: "emergency=phone";
     52        fixAdd: "emergency=phone";
     53        fixRemove: "amenity"
     54}
     55
     56
     57*[amenity = florist],
     58*[shop = floristry],
     59*[shop = flower],
     60*[shop = flowers] {
     61        throwWarning: "{0.tag} is deprecated";
     62    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     63        suggestAlternative: "shop=florist";
     64        fixAdd: "shop=florist";
     65        fixRemove: "amenity"
     66}
     67
     68
     69*[amenity = butcher],
     70*[shop = butchers] {
     71        throwWarning: "{0.tag} is deprecated";
     72    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     73        suggestAlternative: "shop=butcher";
     74        fixAdd: "shop=butcher";
     75        fixRemove: "amenity"
     76}
     77
     78
     79*[shop *= "car school"],
     80*[shop = car_school],
     81*[shop *= "driver's education"],
     82*[shop *= "driving school"],
     83*[shop *= "driver education"] {
     84        throwWarning: tr("{0}", "{0.tag}");
     85        suggestAlternative: "shop=driving_school";
     86        fixAdd: "shop=car_school";
     87}
     88
     89
     90*[shop=bakers]{
     91        throwWarning: "{0.tag} is deprecated";
     92    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     93        suggestAlternative: "shop=bakery";
     94        fixAdd: "shop=bakery";
     95}
     96
     97
     98*[shop=bakers]{
     99        throwWarning: "{0.tag} is deprecated";
     100    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     101        suggestAlternative: "shop=bakery";
     102        fixAdd: "shop=bakery";
     103}
     104
     105*[shop = garden],
     106*[shop *= "garden shop"],
     107*[shop = garden_center],
     108*[shop = gardening]{
     109        throwWarning: "{0.tag} is deprecated";
     110    group: tr("deprecated tagging - Osmose tagwatch cleaner 3030");             
     111        suggestAlternative: "shop=garden_centre";
     112        fixAdd: "shop=garden_centre"
     113}
     114
     115/* Deprecated Tags-- OSMOSE disused Item 4010*/
     116/* For deprecated tags not already found by JOSM */
     117
     118*[aerialway=canopy]{
     119        throwWarning: "{0.tag} is deprecated";
     120    group: tr("deprecated tagging - Osmose disused 4010");
     121        suggestAlternative: "aerialway=zip_line";
     122        fixAdd: "aerialway=zipline";
     123}
     124*[amenity=abandoned]{
     125        throwWarning: "{0.tag} is deprecated";
     126    group: tr("deprecated tagging - Osmose disused 4010");
     127        suggestAlternative: "abandoned:amenity=*"
     128}
     129*[amenity=citymap_post]{
     130        throwWarning: "{0.tag} is deprecated";
     131    group: tr("deprecated tagging - Osmose disused 4010");
     132        suggestAlternative: "tourism=information";
     133        fixRemove: "amenity";
     134        fixAdd: "tourism=information";
     135}
     136*[amenity=creche]{
     137        throwWarning: "{0.tag} is deprecated";
     138    group: tr("deprecated tagging - Osmose disused 4010");
     139        suggestAlternative: "amenity=childcare or amenity=kindergarten"
     140}
     141*[amenity=ev_charging],
     142*[amenity=charging]{
     143        throwWarning: "{0.tag} is deprecated";
     144    group: tr("deprecated tagging - Osmose disused 4010");
     145        suggestAlternative: "amenity=charging_station";
     146        fixRemove: "amenity";
     147        fixAdd: "amenity=charging_station";
     148}
     149*[amenity=fire_hydrant]{
     150        throwWarning: "{0.tag} is deprecated";
     151    group: tr("deprecated tagging - Osmose disused 4010");   
     152        suggestAlternative: "emergency=fire_hydrant";
     153        fixRemove: "amenity";
     154        fixAdd: "emergency=fire_hydrant";
     155}
     156*[amenity=garages],
     157*[amenity=garage]{
     158        throwWarning: "{0.tag} is deprecated";
     159    group: tr("deprecated tagging - Osmose disused 4010");
     160        suggestAlternative: "amenity=parking + parking=* or landuse=garages";
     161}
     162*[amenity=nursery]{
     163        throwWarning: "{0.tag} is deprecated";
     164    group: tr("deprecated tagging - Osmose disused 4010");
     165        suggestAlternative: "amenity=childcare or amenity=kindergarten";
     166}
     167*[amenity=preschool]{
     168        throwWarning: "{0.tag} is deprecated";
     169    group: tr("deprecated tagging - Osmose disused 4010");
     170        suggestAlternative: "amenity=kindergarten";
     171        fixAdd: "amenity=kindergarten";
     172}
     173*[amenity=real_estate]{
     174        throwWarning: "{0.tag} is deprecated";
     175    group: tr("deprecated tagging - Osmose disused 4010");
     176        suggestAlternative: "office=estate_agent";
     177        fixRemove: "amenity";
     178        fixAdd: "office=estate_agent";
     179}
     180*[office=real_estate]{
     181        throwWarning: "{0.tag} is deprecated";
     182    group: tr("deprecated tagging - Osmose disused 4010");
     183        suggestAlternative: "office=estate_agent";
     184        fixAdd: "office=estate_agent";
     185}
     186*[shop=real_estate]{
     187        throwWarning: "{0.tag} is deprecated";
     188    group: tr("deprecated tagging - Osmose disused 4010");
     189        suggestAlternative: "office=estate_agent";
     190        fixRemove: "shop";
     191        fixAdd: "office=estate_agent";
     192}
     193*[amenity=sauna]{
     194        throwWarning: "{0.tag} is deprecated";
     195    group: tr("deprecated tagging - Osmose disused 4010");
     196        suggestAlternative: "leisure=sauna";
     197        fixRemove: "amenity";
     198        fixAdd: "leisure=sauna";
     199}
     200*[amenity=winery]{
     201        throwWarning: "{0.tag} is deprecated";
     202    group: tr("deprecated tagging - Osmose disused 4010");
     203        suggestAlternative: "shop=winery or craft=winery";
     204}
     205*[amenity=youth_centre],
     206*[amenity=youth_center]{
     207        throwWarning: "{0.tag} is deprecated";
     208    group: tr("deprecated tagging - Osmose disused 4010");
     209        suggestAlternative: "amenity=community_centre + community_centre:for=juvenile or community_centre:for=child;juvenile";
     210}
     211*[bridge=arch],
     212*[bridge=beam],
     213*[bridge=humpback],
     214*[bridge=suspension]{
     215        throwWarning: "{0.tag} is deprecated";
     216    group: tr("deprecated tagging - Osmose disused 4010");
     217        suggestAlternative: "bridge=yes + bridge:structure={0.value}";
     218        fixAdd: "bridge=yes";
     219        fixAdd: "bridge:structure={0.value}";
     220}
     221*[bridge=lift],
     222*[bridge=swing]{
     223        throwWarning: "{0.tag} is deprecated";
     224    group: tr("deprecated tagging - Osmose disused 4010");
     225    suggestAlternative: "bridge=movable + bridge:structure={0.value}";
     226    fixAdd: "bridge=movable";
     227    fixAdd: "bridge:structure={0.value}";
     228}
     229*[bridge=pontoon]{
     230        throwWarning: "{0.tag} is deprecated";
     231    group: tr("deprecated tagging - Osmose disused 4010");
     232        suggestAlternative: "bridge=yes + bridge:structure=floating";
     233        fixAdd: "bridge=yes";
     234        fixAdd: "bridge:structure=floating";
     235}
     236*[building:type]{
     237        throwWarning: "{0.tag} is deprecated";
     238    group: tr("deprecated tagging - Osmose disused 4010");
     239        suggestAlternative: "building=*";
     240}
     241*[escalator]{
     242        throwWarning: "{0.tag} is deprecated";
     243    group: tr("deprecated tagging - Osmose disused 4010");
     244        suggestAlternative: "highway=steps + conveying=*";
     245}
     246*[fenced]{
     247        throwWarning: "{0.tag} is deprecated";
     248    group: tr("deprecated tagging - Osmose disused 4010");
     249        suggestAlternative: "barrier=fence";
     250        fixRemove: "fenced";
     251        fixAdd: "barrier=fence";
     252}
     253*[highway=abandoned]{
     254        throwWarning: "{0.tag} is deprecated";
     255    group: tr("deprecated tagging - Osmose disused 4010");
     256        suggestAlternative: "abandoned:highway=*";
     257}
     258*[highway=minor]{
     259        throwWarning: "{0.tag} is deprecated";
     260    group: tr("deprecated tagging - Osmose disused 4010");
     261        suggestAlternative: "highway=tertiary or highway=unclassified or highway=service";
     262}
     263*[historic_name]{
     264        throwWarning: "{0.tag} is deprecated";
     265    group: tr("deprecated tagging - Osmose disused 4010");
     266        suggestAlternative: "old_name=* or name=*";
     267}
     268*[historic=museum]{
     269        throwWarning: "{0.tag} is deprecated";
     270    group: tr("deprecated tagging - Osmose disused 4010");
     271        suggestAlternative: "tourism=museum";
     272        fixRemove: "historic";
     273        fixAdd: "tourism=museum";
     274}
     275*[landuse=field]{
     276        throwWarning: "{0.tag} is deprecated";
     277    group: tr("deprecated tagging - Osmose disused 4010");
     278        suggestAlternative: "landuse=farmland";
     279        fixAdd: "landuse=farmland";
     280}
     281*[leisure=beach]{
     282        throwWarning: "{0.tag} is deprecated";
     283    group: tr("deprecated tagging - Osmose disused 4010");
     284        suggestAlternative: "natural=beach";
     285        fixRemove: "leisure";
     286        fixAdd: "natural=beach";
     287}
     288*[leisure=club]{
     289        throwWarning: "{0.tag} is deprecated";
     290    group: tr("deprecated tagging - Osmose disused 4010");
     291        suggestAlternative: "club=*";
     292}
     293*[leisure=video_arcade]{
     294        throwWarning: "{0.tag} is deprecated";
     295    group: tr("deprecated tagging - Osmose disused 4010");
     296        suggestAlternative: "leisure=adult_gaming_centre or leisure=amusement_arcade";
     297}
     298*[man_made=cooling_tower]{
     299        throwWarning: "{0.tag} is deprecated";
     300    group: tr("deprecated tagging - Osmose disused 4010");
     301        suggestAlternative: "man_made=tower + tower:type=cooling";
     302        fixAdd: "man_made=tower";
     303        fixAdd: "tower:type=cooling";
     304}
     305*[man_made=hot_water_tank]{
     306        throwWarning: "{0.tag} is deprecated";
     307    group: tr("deprecated tagging - Osmose disused 4010");
     308        suggestAlternative: "man_made=storage_tank + content=hot_water";
     309        fixAdd: "man_made=storage_tank";
     310        fixAdd: "content=hot_water";
     311}
     312*[man_made=jetty]{
     313        throwWarning: "{0.tag} is deprecated";
     314    group: tr("deprecated tagging - Osmose disused 4010");   
     315        suggestAlternative: "man_made=pier";
     316        fixAdd: "man_made=pier";
     317}
     318*[man_made=village_pump]{
     319        throwWarning: "{0.tag} is deprecated";
     320    group: tr("deprecated tagging - Osmose disused 4010");
     321        suggestAlternative: "man_made=water_well";
     322        fixAdd: "man_made=water_well";
     323}
     324*[man_made=water_tank]{
     325            throwWarning: "{0.tag} is deprecated";
     326    group: tr("deprecated tagging - Osmose disused 4010");
     327    suggestAlternative: "man_made=storage_tank + content=water";
     328    fixAdd: "man_made=storage_tank";
     329    fixAdd: "content=water";
     330}
     331*[natural=moor]{
     332        throwWarning: "{0.tag} is deprecated";
     333    group: tr("deprecated tagging - Osmose disused 4010");
     334}
     335*[noexit=no]{
     336        throwWarning: "{0.tag} is deprecated";
     337    group: tr("deprecated tagging - Osmose disused 4010");
     338    suggestAlternative: "fixme=continue";
     339}
     340*[office=administrative]{
     341        throwWarning: "{0.tag} is deprecated";
     342    group: tr("deprecated tagging - Osmose disused 4010");
     343        suggestAlternative: "office=government";
     344        fixAdd: "office=government";
     345}
     346*[power=underground_cable]{
     347        throwWarning: "{0.tag} is deprecated";
     348    group: tr("deprecated tagging - Osmose disused 4010");
     349        suggestAlternative: "power=cable + location=underground";
     350        fixAdd: "power=cable";
     351        fixAdd: "location=underground";
     352}
     353*[railway=preserved]{
     354        throwWarning: "{0.tag} is deprecated";
     355    group: tr("deprecated tagging - Osmose disused 4010");
     356        suggestAlternative: "historic=railway + railway= + railway:preserved=yes";
     357}
     358*[shop=dive]{
     359        throwWarning: "{0.tag} is deprecated";
     360    group: tr("deprecated tagging - Osmose disused 4010");
     361        suggestAlternative: "shop=scuba_diving";
     362        fixAdd: "shop=scuba_diving";
     363}
     364*[shop=furnace]{
     365        throwWarning: "{0.tag} is deprecated";
     366    group: tr("deprecated tagging - Osmose disused 4010");
     367        suggestAlternative: "shop=fireplace or shop=houseware";
     368}
     369*[shop=moneylender]{
     370        throwWarning: "{0.tag} is deprecated";
     371    group: tr("deprecated tagging - Osmose disused 4010");
     372        suggestAlternative: "shop=money_lender";
     373        fixAdd: "shop=money_lender";
     374}
     375*[sport=paragliding]{
     376        throwWarning: "{0.tag} is deprecated";
     377    group: tr("deprecated tagging - Osmose disused 4010");
     378        suggestAlternative: "sport=free_flying";
     379        fixAdd: "sport=free_flying";
     380}
     381*[tourism=bed_and_breakfast]{
     382        throwWarning: "{0.tag} is deprecated";
     383    group: tr("deprecated tagging - Osmose disused 4010");
     384        suggestAlternative: "tourism=guest_house + guest_house=bed_and_breakfast";
     385        fixAdd: "tourism=guest_house";
     386        fixAdd: "guest_house=bed_and_breakfast";
     387}
     388*[wood]{
     389        throwWarning: "{0.tag} is deprecated";
     390    group: tr("deprecated tagging - Osmose disused 4010");
     391        suggestAlternative: "leaf_type=*";
     392}
     393*[man_made=MDF],
     394*[man_made=mdf]{
     395        throwWarning: "{0.tag} is deprecated";
     396    group: tr("deprecated tagging - Osmose disused 4010");
     397        suggestAlternative: "telecom=exchange";
     398        fixRemove: "man_made";
     399        fixAdd: "telecom=exchange";
     400}
     401
     402/* elevation 2020 */
     403node[natural=peak][!ele], node[mountain_pass=yes][!ele]{
     404        throwError: "Missing {1.key} tag (elevation)";
     405    group: tr("elevation - Osmose 2020");                       
     406}
     407
     408/* note 3110 */
     409*[note]{
     410        throwWarning: "For {0.key}, description or opening_hours tag more appropriate? if not";
     411        suggestAlternative: "fixme";
     412    group: tr("note - Osmose 3110");                   
     413}
     414
     415/* place without name 6030 */
     416*[place][!name]{
     417        throwError: "{0.key} without {1.key}";
     418    group: tr("place without name - Osmose 6030");                             
     419}
     420
     421}}}