Changes between Version 22 and Version 23 of Rules/PublicTransportGtfs

Timestamp:

2020-08-13T02:16:42+02:00 (6 years ago)

Author:

skyper

Comment:

Warn about abbreviations of network and operator; Only warn about missing gtfs:source_date with GTFS-tags

Rules/PublicTransportGtfs

@@ -111 +111 @@
 relation.PtRouteMaster[type=route_master][!gtfs:name],
 relation.PtRouteMaster[type=route_master][!gtfs:route_id],
-relation.PtRouteMaster[type=route_master][!gtfs:source_date],
 relation.PtRouteMaster[type=route_master][!network],
 relation.PtRouteMaster[type=route_master][!operator],
@@ -125 +124 @@
 relation.PtRoute[type=route][!gtfs:name]["public_transport:version"=1],
 relation.PtRoute[type=route][!gtfs:route_id],
-relation.PtRoute[type=route][!gtfs:source_date],
 relation.PtRoute[type=route][!network],
 relation.PtRoute[type=route][!opening_hours],
@@ -219 +217 @@
 }
 
+/* One of many {0.key} but no {1.key} */
+
+/* gtfs:source_date */
+*[/(^gtfs:|:gtfs|^ref:IFOPT)/][!gtfs:source_date] {
+  throwWarning: tr("GTFS tag without `{0}*`.", "{1.tag}");
+  group: tr("Public Transport GTFS: missing tag");
+  assertMatch:   "node gtfs:route_id=1";
+  assertMatch:   "node note:gtfs=A";
+  assertMatch:   "node ref:IFOPT=1";
+  assertNoMatch: "node ref:IFOPT=1 gtfs:source_date=2019";
+} 
 
 /*  -----------------------
@@ -344 +353 @@
 }
 
+/* abbreviatons */
+
+/* network */
+*[public_transport   ][network][!network:short][network =~ /^[A-Z0-9]+$/],
+relation.PtRouteMaster[network][!network:short][network =~ /^[A-Z0-9]+$/],
+relation.PtRoute[network      ][!network:short][network =~ /^[A-Z0-9]+$/] {
+  throwWarning: tr(" `{0}` looks like an abbreviation", "{1.tag}");
+  group: tr("Public Transport GTFS: value syntax");
+  suggestAlternative: "`network:short=*` and a longer form for `network=*`"; 
+  fixChangeKey: "network=>network:short";
+  assertMatch:   "relation public_transport=stop_area network=AA0AA";
+  assertNoMatch: "relation public_transport=stop_area network=AA0AA network:short=A";
+  assertNoMatch: "relation public_transport=stop_area network=Anna";
+}
+
+/* operator */
+*[public_transport   ][operator][!operator:short][operator =~ /^[A-Z0-9]+$/],
+relation.PtRouteMaster[operator][!operator:short][operator =~ /^[A-Z0-9]+$/],
+relation.PtRoute[operator      ][!operator:short][operator =~ /^[A-Z0-9]+$/] {
+  throwWarning: tr(" `{0}` looks like an abbreviation", "{1.tag}");
+  group: tr("Public Transport GTFS: value syntax");
+  suggestAlternative: "`operator:short=*` and a longer form for `operator=*`"; 
+  fixChangeKey: "operator=>operator:short";
+  assertMatch:   "relation public_transport=stop_area operator=AA0AA";
+  assertNoMatch: "relation public_transport=stop_area operator=AA0AA operator:short=A";
+  assertNoMatch: "relation public_transport=stop_area operator=Anna";
+}
+
 /*  -----------------------
  *  conflicting tags