| | 1 | = How to get an JOSM SVN account = |
| | 2 | |
| | 3 | There are two different types of SVN accounts |
| | 4 | * JOSM core account - You only get an account for JOSM core after you supplied useful patches for some time using the bug tracker. There is no need to ask for it, the current maintainer will ask you. |
| | 5 | * OSM account - This account is needed to change plugins. This is the same account as for all the other OSM projects. See also [http://wiki.openstreetmap.org/index.php/Accounts#SVN_access_.28OSM_software.29 here]. |
| | 6 | |
| | 7 | = Rules for JOSM account = |
| | 8 | * No edit wars. |
| | 9 | * Larger changes (or changes which very likely break the code) should be discussed at mailinglist first. |
| | 10 | * No changes in code without a reason. Don't change anything only to have it look nicer (i.e. adding setters/getters). There should always be benefit for the compiled software even if it is a long-term-goal. |
| | 11 | * Do code as it is already done elsewhere in code except you have good reason not to do so. |
| | 12 | * Don't introduce larger changes in the stabilization phase before a release. |
| | 13 | * JOSMSVN uses https for checkins. Easiest usage is to checkout JOSM directory in OSM SVN and change the link for core from http to https. |
| | 14 | |
| | 15 | = Some general rules for SVN usage = |
| | 16 | * Check your code before doing a checkin. |
| | 17 | * Are all changes useful? |
| | 18 | * No debug parts left? |
| | 19 | * All new files included? |
| | 20 | * When you have a different view, don't change code, but contact original author first. |
| | 21 | * Error can be correct, but never made undone. |
| | 22 | * Reworking code needs tactfulness. |
| | 23 | * Don't take code changes personal - nobody owns parts of the code. |
