Changes between Version 6 and Version 7 of DevelopersGuide/PatchGuide


Ignore:
Timestamp:
2013-07-25T10:59:19+02:00 (12 years ago)
Author:
bastiK
Comment:

change wording

Legend:

Unmodified
Added
Removed
Modified
  • DevelopersGuide/PatchGuide

    v6 v7  
    1111* Even if you changed just a single file, create the patch from the root folder of the JOSM source repository.
    1212* Keep the patch as readable as possible: Do not correct the formatting / indentation of any code that need not be changed. Do not unnecessarily reorder methods, etc. (Improvements of the documentation are always welcome, though.)
    13 
    1413* Changeset sizes:
    15  * If you have multiple related changes, it is usually better to combine them all in one big patch, rather than attaching a long list of diffs. However, sometimes it may be useful to split the more controversial parts of the changes from those that can be applied without discussion.
    16  * Large changes should be split:
    17    * first required infrastructure changes in smaller parts
    18    * final work later (should be small as well, after infrastructure fixes are applied)
    19  * NOTE: These two points aren't opposites! Everything related should be joined (point 1), but idea is to extract independent sub-tasks from each large job (point 2).
     14 * If you have multiple related changes, it is usually better to combine them all in one big patch, rather than attaching a long list of diffs. However, sometimes it may be useful to split the more controversial parts of the changes from those that can be applied without discussion. This applies to very large patches as well: If there is a lot of technical rework required, then it can be a good idea to separate this from the interesting new code. This should make it easier to understand and discuss the important parts your patch.
    2015
    2116Please be patient — there can be various reasons, why your patch is not dealt with. If you don't get any reaction for two weeks, it may be a good idea to bring the topic up again and ask for a status update.