Changes between Version 3 and Version 4 of DevelopersGuide/PatchGuide

Timestamp:

2013-03-26T18:42:51+01:00 (13 years ago)

Author:

stoecker

Comment:

--

DevelopersGuide/PatchGuide

@@ -11 +11 @@
 * Even if you changed just a single file, create the patch from the root folder of the JOSM source repository.
 * Keep the patch as readable as possible: Do not correct the formatting / indentation of any code that need not be changed. Do not unnecessarily reorder methods, etc. (Improvements of the documentation are always welcome, though.)
-* If you have multiple related changes, it is usually better to combine them all in one big patch, rather than attaching a long list of diffs. However, sometimes it may be useful to split the more controversial parts of the changes from those that can be applied without discussion.
-* Large changes should be splitted:
+
+* Changeset sizes:
+ * If you have multiple related changes, it is usually better to combine them all in one big patch, rather than attaching a long list of diffs. However, sometimes it may be useful to split the more controversial parts of the changes from those that can be applied without discussion.
+ * Large changes should be split:
    * first required infrastructure changes in smaller parts
-   * final work later (should be small as well, after infrastructe fixes are applied)
+   * final work later (should be small as well, after infrastructure fixes are applied)
+ * NOTE: These two points aren't opposites! Everything related should be joined (point 1), but idea is to extract independent sub-tasks from each large job (point 2).
 
 Please be patient—there can be various reasons, why your patch is not dealt with. If you don't get any reaction for two weeks, it may be a good idea to bring the topic up again and ask for a status update.