Changes between Version 11 and Version 12 of DevelopersGuide/PatchGuide
- Timestamp:
- 2023-08-01T20:26:23+02:00 (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
DevelopersGuide/PatchGuide
v11 v12 15 15 * Changeset sizes: 16 16 * If you have multiple related changes, it is usually better to combine them all into one big patch, rather than attaching a long list of diffs. However, sometimes it may be useful to split the more controversial parts of the changes from those that can be applied without discussion. This applies to very large patches as well: If there is a lot of technical rework required it can be a good idea to separate this from the interesting new code. This should make it easier to understand and discuss the important parts of your patch. 17 17 * Make sure to run style checks, static analysis and tests on your patch (in one command with `ant checkstyle pmd test`). See [wiki:DevelopersGuide/StyleGuide] for details on checkstyle and [wiki:DevelopersGuide/Compiling] for details on unit tests. 18 18 Please be patient — there can be various reasons why your patch is not dealt with right away. If you don't get any reaction for two weeks, it may be a good idea to bring the topic up again and ask for a status update. 19 19
