Changes between Version 21 and Version 22 of DevelopersGuide/DefaultPresets


Ignore:
Timestamp:
2016-01-30T16:11:20+01:00 (9 years ago)
Author:
Klumbumbus
Comment:

a bit more info

Legend:

Unmodified
Added
Removed
Modified

  • DevelopersGuide/DefaultPresets

    v21 v22  
    22= Defaultpresets Guidelines
    33
    4 Some rough guidelines for the [source:trunk/data/defaultpresets.xml defaultpresets] (Starting point was ticket:10246#comment:14)
     4Some rough guidelines for the [source:trunk/data/defaultpresets.xml defaultpresets] and new icons.
    55
    66== New Tags and Values
    … …  
    88* a proper documentation in the [osmwiki: OSM-wiki]
    99* decent usage numbers (absolute and by number of mappers)
    10 * Controversial cases (like `contact:phone=*` vs. `phone=*`) need to be decided case by case
    11 * If a features is only mapped by a handful of specialists, it is better suited for an [wiki:Presets#Createnewpresets external preset]. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession.
     10* world wide usage
     11* Controversial cases (like `contact:phone=*` vs. `phone=*`) need to be decided case by case.
     12* If a features is only mapped by a handful of specialists, it is better suited for an [wiki:Presets#Createnewpresets external preset]. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession. Instead of creating an own external preset you could also extend [wiki:Presets/NewTags].
    1213
    1314**Note**:
    1415* When investigating [https://taginfo.openstreetmap.org taginfo], also check **where** unusual values are used.
    15  * You can use overpass API to load these object in JOSM and check in the history who created them.
    16 
     16* You can use overpass API to load these object in JOSM and check in the history who created them.
     17* See also [osmwiki:DE:Overpass_API/Beispielsammlung#User_f.C3.BCr_bestimmte_Tag-Kombination_ausgeben this example] to search for the last editor of an specific tag.
    1718* When modifying the defaultpresets also the [source:josm/trunk/styles/standard/elemstyles.mapcss main mappaint style] and maybe also [source:josm/trunk/data/validator validator rules] should be changed for consistency.
    1819
    … …  
    2122* Check if the svg file correctly works with JOSM. There are some svg libraries which do not work with JOSM (the images get deformed). If you have such a file try the following workaround: create a new svg document with Inkscape, copy the svg data to this new file, resize the page to the data and save.
    2223* Check the code of the file in a text editor. Search for '''viewBox''' value in the beginning of the file. If the icon is, for example, in 16x16 pixels, and if you made it in Inkscape (at least this happens in 0.91 version) and have defined in Document Properties 16,00000 by 16,00000 pixels, probably in the file code you have these values '''viewBox="0 0 16.000002 16.000001"'''. Change it to '''viewBox="0 0 16 16"''' or you will have problems (see #12201 and the fix [o31865])
    23 * svg icons are automatically cleaned up to reduce file size in the JOSM build. So there is no need to do this step manually before uploading svg files to svn. See comment:35:ticket:10479 and comment:10:ticket:10877
     24* svg icons are automatically cleaned up to reduce file size in the JOSM build. So there is no need to do this step manually before uploading svg files to svn. See comment:35:ticket:10479, comment:10:ticket:10877 and ticket:12201#comment:21
    2425* The icon should be identifiable at a size of '''16 pixels'''. This is the size the icons are displayed in the [[Help/MapView|Map View]].
    2526* The '''license''' needs to be compatible with GPL3 (like PD or CC0). A good source for Icons is [http://openclipart.org openclipart.org] (all icons there are PD). You can also check if JOSM already has a fitting unused icon in one of its icon folders: [browser:josm/trunk/images 1], [browser:josm/trunk/images_nodist 2], [https://trac.openstreetmap.org/browser/subversion/applications/share/map-icons/classic.small 3].
    … …  
    2930* The icon should be understandable in all countries.
    3031
     32== See also
     33Starting point for these rules was ticket:10246#comment:14.
     34
    3135----
    3236Back to [wiki:/DevelopersGuide Developers Guide]