Hide toggle dialog header context menu item dynamic side bar buttons when disabled through preferences

[skyper]

As default settings were changed and dynamic buttons are disabled in preferences the middle entry for sidebars (dynamic) in the toogle dialog header context menu should be hidden as it does not work and is rather confusing.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-04-19 01:33:11
Last Changed Author: Don-vip
Revision: 6990
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-04-19 00:36:43 +0200 (Sat, 19 Apr 2014)
Last Changed Rev: 6990

Identification: JOSM/1.5 (6990 en) Linux Debian GNU/Linux 7.4 (wheezy)
Memory Usage: 593 MB / 881 MB (266 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u25-2.3.10-1~deb7u1
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (30375)
Plugin: conflation (0.1.6)
Plugin: imagery-xml-bounds (30393)
Plugin: jts (30277)
Plugin: mirrored_download (30375)
Plugin: notes (v0.9.2)
Plugin: photoadjust (30277)
Plugin: reverter (30375)
Plugin: terracer (30375)
Plugin: todo (29154)
Plugin: undelete (30375)
Plugin: utilsplugin2 (30391)
Plugin: wikipedia (30375)

[skyper]

screenshot

[skyper]

I was looking at this issue once again and came to the conclusion that a cleaner solution would be to drop this preference entry for good. As the default did change to "allways show" I do not see any advantage in hiding the feature of "dynamic" and it needs user action to activate it which means the user should be aware of it.

[skyper]

Still can reproduce, starting with empty preferences (e.g. "dynamic" buttons disable in preference):

• displayed default is "Dynamic" which should be "Always shown".
• "Dynamic" is available but does not work as disabled in preferences, please, hide this option.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-08 18:20:25 +0200 (Wed, 08 Apr 2020)
Revision:16245
Build-Date:2020-04-09 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk