Changes between Initial Version and Version 1 of Ticket #9611, comment 5
- Timestamp:
- 2014-01-31T19:00:46+01:00 (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #9611, comment 5
initial v1 1 1 OK, if this is the right definition of OsmPrimitiveType, that is used in the dialog, how is the translation supposed to choose the right form? 2 {{{ 3 #!java 2 4 public enum OsmPrimitiveType { 3 5 NODE (marktr(/* ICON(data/) */"node"), Node.class, NodeData.class), 4 6 WAY (marktr(/* ICON(data/) */"way"), Way.class, WayData.class), 5 7 RELATION (marktr(/* ICON(data/) */"relation"), Relation.class, RelationData.class), 8 }}} 6 9 7 10 8 11 In our sk.po file the translation looks like this: 12 {{{ 9 13 #: ../core/src/org/openstreetmap/josm/data/osm/OsmPrimitiveType.java:13 10 14 #: ../core/src/org/openstreetmap/josm/data/validation/util/NameVisitor.java:47 … … 15 19 msgstr[1] "bod" 16 20 msgstr[2] "body" 21 }}} 17 22 18 23 As there is no count specified ("how many nodes") it looks like this chooses the first form found, which incidentally is a plural form (for a number 5+) in SK language. 19 There is no {0} placeholder in that string so this string can't be properly translated (the current state is just a random guess) as there is no context attached and you use this string in different contexts. I have already indicated this in ticket 9110 comment5.24 There is no {0} placeholder in that string so this string can't be properly translated (the current state is just a random guess) as there is no context attached and you use this string in different contexts. I have already indicated this in ticket:9110#comment:5. 20 25 21 26 The order of the plural forms in our sk.po file also seems strange and poedit complains about it. 22 27 This is set in the file header as 28 {{{ 23 29 "Plural-Forms: nplurals=3; plural=(n==1) ? 1 : (n>=2 && n<=4) ? 2 : 0;\n" 30 }}} 24 31 I don't know who or which app sets it and if it is any problem. 25 32 The natural order of the forms would be: 33 {{{ 26 34 msgstr[0] "bod" 27 35 msgstr[1] "body" 28 36 msgstr[2] "bodov" 37 }}} 29 38 30 39 So incidentally, this ordering could fix this bug, but I think it should be fixed properly in the string itself and its context.