Opened 12 years ago

Last modified 12 years ago

#9379 closed enhancement

detect highway=motorway, primary, secondary, tertiary (etc) with foot=yes as bogus — at Version 17

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 14.01
Component: Core validator Version:
Keywords: Cc:

Description (last modified by mkoniecz)

foot=designated also is certainly (I think) bogus

osmwww:browse/way/126376304 was affected till manual detection and fix

suggested list of highway types included in this check: motorway, motorway_link trunk, trunk_link, primary, primary_link, secondary, secondary_link, tertiary, tertiary_link

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-11-27 17:47:56
Last Changed Author: Don-vip
Revision: 6418
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-26 17:24:06 +0100 (Tue, 26 Nov 2013)
Last Changed Rev: 6418

Identification: JOSM/1.5 (6418 en_GB) Windows 7 32-Bit
Memory Usage: 87 MB / 247 MB (14 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: notes (v0.6)

Change History (17)

comment:1 by mkoniecz, 12 years ago

Summary: detect highway=motorway, primary, secondary, tertiary with foot=yes as bogusdetect highway=motorway, primary, secondary, tertiary (etc) with foot=yes as bogus

comment:2 by mkoniecz, 12 years ago

Description: modified (diff)

comment:3 by Don-vip, 12 years ago

Milestone: 14.01

comment:4 by simon04, 12 years ago

This would result in many false-positives in Austria: Here, many primary/secondary/tertiary streets have sidewalks. It would be okay for motorway.

comment:5 by mkoniecz, 12 years ago

So it is a third method for marking sidewalks after separate footways and sidewalk key? Great.

comment:6 by Don-vip, 12 years ago

in this case foot=* should indeed be replaced by sidewalk=*

comment:7 by simon04, 12 years ago

Hm, I wasn't so sure about the tagging scheme for sidewalks.

To summarize, neither foot=yes nor foot=no makes sense (since foot=no is the default), and foot=yes can/should be replaced by sidewalk?

comment:8 by mkoniecz, 12 years ago

foot=yes can be replaced by sidewalk field, or by a separate footway, or removed - in some cases this value is bogus.

comment:9 by simon04, 12 years ago

Resolution: fixed
Status: newclosed

In 6549/josm:

fix #9379 - Add validator warning: "foot used with highway=motorway|trunk|primary|secondary|tertiary, use sidewalk or separate footway instead"

comment:10 by aceman, 12 years ago

Resolution: fixed
Status: closedreopened

This warning is triggered also for foot=no (+highway=motorway). That is bogus as in may countries foot=yes is the default for most road classes (specifically when there is no sidewalk). So foot=no is needed for some roads where pedestrians are specifically forbidden (via road sign). See http://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access-Restrictions .
Please tweak the patch. If you want the warning for foot=yes, then fine, but for foot=no it the suggestion text is bogus. I don't see where you check for foot=yes in the patch.

comment:11 by mkoniecz, 12 years ago

I am surprised by http://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access-Restrictions#Default

on highway=trunk foot defaults to yes? It is ridiculous.

comment:12 by aceman, 12 years ago

You should probably make a separate table for your country if the defaults are not right there. In our table (Slovakia) we have foot=no on trunk. But in some country-specific tables you can see people have specifically set foot=yes, so it does not appear that ridiculous.

in reply to:  11 comment:13 by Don-vip, 12 years ago

Replying to Bulwersator:

on highway=trunk foot defaults to yes? It is ridiculous.

+1, as horse and bicycle...

comment:14 by simon04, 12 years ago

What about classifying this validation result as "information" instead of "warning"?

comment:15 by aceman, 12 years ago

I do not fully understand what is actually wrong with foot=yes on a road (you can officially walk on the road surface itself even when there are no sidewalks) and what this ticket wants to achieve. Anyway, the description of the ticket mentions foot=yes, not foot=no so if the check suddenly does something also with foot=no (and it does) then the feature should be properly described and documented here. Without that, we can't decide if the check is working properly and what class it whould be.

comment:16 by simon04, 12 years ago

The code is readable like a book, so please refer to comment+diff of r6549 and Help/Validator/MapCSSTagChecker before asking for even more documentation.

foot=yes might indicate a problem since you might not be allowed to walk on major roads, and foot=no might be superfluous since that might be considered superfluous.

comment:17 by mkoniecz, 12 years ago

Description: modified (diff)

"you can officially walk on the road surface itself even when there are no sidewalks"

Note "motorway|trunk|primary|secondary|tertiary" check. Can you give example of road in this class where you can walk on carriageway?

Last edited 12 years ago by mkoniecz (previous) (diff)
Note: See TracTickets for help on using tickets.