Plugin reverter crash with openstreetmap.fr server

[anonymous]

What steps will reproduce the problem?

1. Setup OSM API URL as explained in ​http://wiki.openstreetmap.org/wiki/Servers/api.openstreetmap.fr
2. Use plugin reverter to revert changeset 16713601

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-07-07 01:34:43
Last Changed Author: Don-vip
Revision: 6056
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-07-07 00:21:33 +0200 (Sun, 07 Jul 2013)
Last Changed Rev: 6056

Identification: JOSM/1.5 (6056 fr) Windows XP 32-Bit
Memory Usage: 371 MB / 989 MB (285 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Xms384M, -Xmx1G]
Dataset consistency test: No problems found

Plugin: FastDraw (29596)
Plugin: PicLayer (29601)
Plugin: SimplifyArea (29435)
Plugin: cadastre-fr (29734)
Plugin: geotools (29435)
Plugin: jts (29613)
Plugin: log4j (29435)
Plugin: opendata (29706)
Plugin: osmose (0.0.20111113.0)
Plugin: reverter (29663)
Plugin: tag2link (29461)
Plugin: turnrestrictions (29435)
Plugin: undelete (29555)
Plugin: utilsplugin2 (29742)
Plugin: wikipedia (29523)

java.lang.IllegalStateException: Cible de fusion manquante pour le type nœud avec l’identifiant 515 118 867
	at reverter.DataSetCommandMerger.getMergeTarget(DataSetCommandMerger.java:53)
	at reverter.DataSetCommandMerger.mergeNode(DataSetCommandMerger.java:73)
	at reverter.DataSetCommandMerger.merge(DataSetCommandMerger.java:149)
	at reverter.DataSetCommandMerger.<init>(DataSetCommandMerger.java:41)
	at reverter.ChangesetReverter.getCommands(ChangesetReverter.java:335)
	at reverter.RevertChangesetTask.realRun(RevertChangesetTask.java:88)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.doRealRun(PleaseWaitRunnable.java:82)
	at org.openstreetmap.josm.gui.PleaseWaitRunnable.run(PleaseWaitRunnable.java:145)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

[Don-vip]

Strange, it works for me.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-07-07 01:34:43
Last Changed Author: Don-vip
Revision: 6056
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-07-07 00:21:33 +0200 (Sun, 07 Jul 2013)
Last Changed Rev: 6056

Identification: JOSM/1.5 (6056 fr) Windows 7 64-Bit
Memory Usage: 199 MB / 906 MB (86 MB allocated, but free)
Java version: 1.7.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Xverify:remote, -Djnlpx.home=C:\Program Files\Java\jre7\bin, -Djnlpx.origFilenameArg=C:\Users\Vincent\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\53\5c3539b5-756d18c5, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Xbootclasspath/a:C:\Program Files\Java\jre7\lib\javaws.jar;C:\Program Files\Java\jre7\lib\deploy.jar;C:\Program Files\Java\jre7\lib\plugin.jar, -Djnlpx.splashport=3345, -Djnlp.application.href=http://josm.openstreetmap.de/download/josm-latest.jnlp, -Djnlpx.jvm=C:\Program Files\Java\jre7\bin\javaw.exe, -Djnlpx.vmargs=-Djnlp.application.href=http://josm.openstreetmap.de/download/josm-latest.jnlp]
Dataset consistency test: No problems found

Plugin: geotools (29435)
Plugin: jts (29613)
Plugin: opendata (29706)
Plugin: reverter (29663)
Plugin: utilsplugin2 (29742)

I only have 6 conflicts, including one for the accused node.

See screenshot:

[anonymous]

It was because I was using api.openstreetmap.fr/api as server...
No problem when i use the default server. I don't know if it's still a bug or not :)

[_sly_]

Hi,

I tried to do a revert with the JOSM revert plugin and the fr API and all went well.
Could the original reporter provide a full session (in command line mode) of what JOSM and the plugin does to trigger the bug ?

Here is what I get (on a changeset I created then reverted) :

$ java -Xms512m -jar ../donnees/sly/josm-tested.jar
Abandon de la mise à jour des greffons après un laps de temps. La mise à jour automatique au démarrage est désactivée.
Conflit silencieux de raccourci clavier: 'menu:view:wireframe'déplacé par 'file:download' vers 'Alt+Maj+F1'.
GET ​http://api.openstreetmap.fr/api/capabilities... OK
chargement du greffon 'reltoolbox' (version 28857)
chargement du greffon 'DirectDownload' (version 28807)
chargement du greffon 'restart' (version 28492)
chargement du greffon 'dataimport' (version 28656)
chargement du greffon 'mirrored_download' (version 28807)
chargement du greffon 'reverter' (version 28820)
RemoteControl: adding command "revert_changeset" (handled by RevertChangesetHandler)
chargement du greffon 'DirectUpload' (version 28807)
chargement du greffon 'multipoly-convert' (version 28807)
RemoteControl::Accepting connections on port 8111
GET ​http://api.openstreetmap.fr/api/0.6/map?bbox=5.9952307,45.6504084,6.00317,45.6541582
L’élément 'note' trouvé dans le flux d’entrée n’est pas défini. Abandon.
L’élément 'meta' trouvé dans le flux d’entrée n’est pas défini. Abandon.
PUT ​http://api.openstreetmap.fr/api/0.6/changeset/create... OK
POST ​http://api.openstreetmap.fr/api/0.6/changeset/16897372/upload... OK
PUT ​http://api.openstreetmap.fr/api/0.6/changeset/16897372/close... OK
GET ​http://api.openstreetmap.fr/api/0.6/map?bbox=5.9952307,45.6504084,6.00317,45.6541582
L’élément 'note' trouvé dans le flux d’entrée n’est pas défini. Abandon.
L’élément 'meta' trouvé dans le flux d’entrée n’est pas défini. Abandon.
GET ​http://api.openstreetmap.fr/api/0.6/map?bbox=5.9951595,45.6500186,6.0032412,45.6545479
L’élément 'note' trouvé dans le flux d’entrée n’est pas défini. Abandon.
L’élément 'meta' trouvé dans le flux d’entrée n’est pas défini. Abandon.
GET ​http://api.openstreetmap.fr/api/0.6/changeset/16897372
GET ​http://api.openstreetmap.fr/api/0.6/changeset/16897372/download
PUT ​http://api.openstreetmap.fr/api/0.6/changeset/create... OK
POST ​http://api.openstreetmap.fr/api/0.6/changeset/16897450/upload... OK
PUT ​http://api.openstreetmap.fr/api/0.6/changeset/16897450/close... OK

[Don-vip]

sly, can you try with the original changeset (16713601) ? (without uploading the revert of course)

[_sly_]

log josm en console du début jusqu'au crash

[_sly_]

I can confirm it does crash with the OP's same error, here is a full consol output from JOSM start to reverter plugin crash

Last call triggering the problem is :
​http://api.openstreetmap.fr/api/0.6/nodes?nodes=515118863,515118866,515118867,515118865,515118868,515118869
because it is empty.

While this one :
​http://api.openstreetmap.org/api/0.6/nodes?nodes=515118863,515118866,515118867,515118865,515118868,515118869
Sends the current state of the 6 nodes i.e : deleted (visible="false")

This is a known limit on the fr api, and this might cause the reverter plugin crash.
I'll adapt the "'api fr" wiki documentation to make it explicit the reverter plugin might crash.

ps: Sorry, I was tired and didn't pay attention I wrote my answer in french at first, I now have translated it ;-)

[Don-vip]

Tu penses pouvoir corriger ça dans l'api Fr ? :)

[Don-vip]

What about extending the "Capabilities" request to add an extra entry about non-supported API calls ? Plugins or core features could then be disabled if the configured API server does not handle required calls.