Changes between Initial Version and Version 1 of Ticket #7277, comment 8


Ignore:
Timestamp:
2012-01-21T05:36:40+01:00 (9 years ago)
Author:
joshdoe
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7277, comment 8

    initial v1  
    22> As for me, I like this version. Only thing I noticed is that node is not included in replacing way, if it is >~100 m away. Maybe we should always include it, because tags are taken from the node before deletion?
    33
    4 Done, and committed. The {{{findNearestNode}}} checks for distance in canvas units with a max hardcoded value of 3e-4. Why this is, I'm not sure, but it seems like it shouldn't have a max value to me. I didn't want to modify the behavior of the classic way->way replacement, so for node->way I just pick the first unimportant node if this check fails. Another ticket for this one, or maybe Zverik can enlighten us?
     4Done and published in [o27517]. The {{{findNearestNode}}} checks for distance in canvas units with a max hardcoded value of 3e-4. Why this is, I'm not sure, but it seems like it shouldn't have a max value to me. I didn't want to modify the behavior of the classic way->way replacement, so for node->way I just pick the first unimportant node if this check fails. Another ticket for this one, or maybe Zverik can enlighten us?