1 | | I have prepared bigger patch described in previous post. |
2 | | |
3 | | It completely removes showing-hiding button logic from ToggleDialog. |
4 | | |
5 | | Showing-Hiding is now concentrated in HideableButton interface implemented by IconToggleButton. |
6 | | Visibility management and context menus are unified now for both left toolbars (addHideContextMenu method and ListAllButtonsAction class are universal). |
7 | | |
8 | | I did not change the signatures of ToggleDialogh class (intensively used by pluguins), but removed many methods. It does not affect the plugins, as I see. None of installed plugin crashes and full plugin recompilation works fine too. |
9 | | |
10 | | Many methods are moved to IconToggleButton, but its existing methods are unchanged. |
11 | | |
12 | | Please, can your review (or rework this patch) when you have enough time. (I will have very busy week myself...) |
| 1 | [delete this - was double post] |