Changes between Version 1 and Version 2 of Ticket #6953, comment 23


Ignore:
Timestamp:
2011-11-12T21:03:54+01:00 (14 years ago)
Author:
akks

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6953, comment 23

    v1 v2  
    11I have a feeling that all button-related methods should be removed from ToggleDialog. All showing/hiding/setting hidden-preferences for button should go to IconToggleButton class, or, better, to HidebleButton interface.
    22
    3 Elsewhere we can not make unified show-hide-button logic for MapModes and ToggleDialogs.
     3Elsewhere we can not implement unified show-hide-button logic for MapModes and ToggleDialogs in MapFrame.
    44
    55Only problem is informing ToggleDialog about its button show-hide. Some events should be added to IconToggleButton (buttonShown, buttonHidden, listened in ToggleDialog) or something else...
    66
     7But this need rather big refactoring (removing 4 public methods) and can lead to plugin recompilation.
     8
    79Maybe I am not right.