Opened 14 years ago

Last modified 13 years ago

#6733 closed defect

[patch] File Open dialog incorrectly accepts folder selection — at Version 5

Reported by: Don-vip Owned by: team
Priority: trivial Milestone:
Component: Core Version: latest
Keywords: JFileChooser Cc:

Description (last modified by richlv)

The JOSM "File, Open" dialog accepts a folder as selected object(s) whereas only files are processed.
This prevents for example to paste a folder path in its file name text area in order to quickly display a folder's contents before selecting a specific file. Instead, the folder is selected by the JFileChooser and JOSM tries to read the folder contents.

Please find attached the patch.

Change History (6)

by Don-vip, 14 years ago

Attachment: patch.diff added

comment:1 by stoecker, 14 years ago

Resolution: wontfix
Status: newclosed

The JOSM open file dialog accepts directories, as when a directory is selected it loads all images from it. This patch would destroy that feature.

comment:2 by bastiK, 14 years ago

It should probably also open all other files it finds in the folder, but this is a different issue.

comment:3 by stoecker, 14 years ago

I thought so also before, but whereas a lot of images is normal, e.g. loading a lot off GPX files surely kills josm, so I think current method is better :-)

comment:4 by Don-vip, 14 years ago

Could it be at least an internal property ? I don't care about this images autoloading, I personally select them all when I want to load all of them... But I definitely want to paste a folder's path in the text input field in order to display its contents without having to reach it by clicking all the way through the explorer :( It's really a non conventional usage to allow folder selection when you want to open files, I find this behaviour very disturbing.

comment:5 by richlv, 13 years ago

Description: modified (diff)
Resolution: wontfix
Status: closedreopened

reopening so this is not forgotten :)

if the entered text in the address/location field is a directory, josm should first display it's contents.

ability to open all files in a directory should be provided by selecting that directory in the file listing, then specifically 'opening' it.

reasoning :

  1. all other software does it that way :)
  2. usecase : i have directory where i store gps traces and images. so occasionally i want to quickly get to that location to open one gps trace. i enter the path, hit 'enter'... and josm tries to open some 20gb of images.
Note: See TracTickets for help on using tickets.