Changes between Initial Version and Version 1 of Ticket #23932, comment 18


Ignore:
Timestamp:
2024-09-23T05:12:01+02:00 (12 months ago)
Author:
huntertur

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23932, comment 18

    initial v1  
    1 Thank you for the `validator.check_assert_local_rules` suggestion; I mistakenly thought those assertions had been getting run as part of `ant test`. I've now edited the developers guide on the wiki to mention this.
     1Thank you for the `validator.check_assert_local_rules` suggestion; I mistakenly thought those assertions had been getting run as part of `ant test`. I've now edited the developers guide on the wiki to mention this. This also masked the fact that I had some broken tests leftover from when I had been iterating on how to write the validation rules.
    22
    33I implemented most of your suggestions in `cycleway_buffer_4.patch`, except for parts of those in the lines 1123-1146 section. I genericized the `cycleway:*:*` checks, except for the plain `cycleway:*` case, because it doesn't look like I can negate a regex in MapCSS, which prevents me from having it ignore `cycleway:left=*` or `cycleway:right=*` while matching everything else. Please correct me if I am wrong!