#23604 closed defect (fixed)
[Patch] false warning: combination of sport and building:part — at Version 3
| Reported by: | Fred73000 | Owned by: | GerdP |
|---|---|---|---|
| Priority: | normal | Milestone: | 24.03 |
| Component: | Core validator | Version: | |
| Keywords: | combination sport building:part | Cc: |
Description (last modified by )
Note : I don't use JOSM so I cannot create a report for this ticket.
The problem in josm is here :
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L545
The problem is : [!"building:part"] is missing.
To illustrate, see this building https://www.openstreetmap.org/way/71485515
This sports_hall has 2 building parts = one big area where people can play basketball, volleyball, handball. And a smaller room dedicated to boxing. The tag "sport" is on each "building:part" but osmose (and probably josm) shows a warning "sport without physical feature" while a physical feature is present.
Change History (4)
by , 16 months ago
| Attachment: | 23604.patch added |
|---|
comment:1 by , 16 months ago
| Milestone: | → 24.03 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Summary: | false warning in osmose because of a problem in JOSM → [Patch] false warning in osmose because of a problem in JOSM |
comment:3 by , 16 months ago
| Component: | Core → Core validator |
|---|---|
| Description: | modified (diff) |
| Keywords: | combination sport building:part added |
| Summary: | [Patch] false warning in osmose because of a problem in JOSM → [Patch] false warning: combination of sport and building:part |
I guess it does not matter for the assertNoMatch but building:part on a node is wrong, in general, and way would be a better choice.
Thanks for the suggested fix. If nobody complains I'll commit the patch tomorrow.