Changes between Version 1 and Version 2 of Ticket #23091, comment 2


Ignore:
Timestamp:
2023-07-31T22:27:04+02:00 (2 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #23091, comment 2

    v1 v2  
    11I was able to reproduce with https://osm.org/relation/16144362 .
    22
    3 I believe
    4 {{{#!diff
    5 Index: src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java
    6 IDEA additional info:
    7 Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
    8 <+>UTF-8
    9 ===================================================================
    10 diff --git a/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java b/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java
    11 --- a/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java        (revision 18788)
    12 +++ b/src/org/openstreetmap/josm/gui/dialogs/relation/GenericRelationEditor.java        (date 1690829714515)
    13 @@ -201,9 +201,7 @@
    14  
    15              @Override
    16              public Collection<OsmPrimitive> getSelection() {
    17 -                Relation relation = new Relation();
    18 -                tagEditorPanel.getModel().applyToPrimitive(relation);
    19 -                return Collections.<OsmPrimitive>singletonList(relation);
    20 +                return Collections.singletonList(getRelation());
    21              }
    22          };
    23  
    24 }}}
    25 will fix the problem. I'll write a test for it first though, if it isn't extraordinarily difficult.
     3I believe [the attached patch] will fix the problem. I'll write a test for it first though, if it isn't extraordinarily difficult.