Changes between Version 3 and Version 4 of Ticket #22957, comment 9


Ignore:
Timestamp:
2023-05-18T19:58:11+02:00 (3 years ago)
Author:
Famlam

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22957, comment 9

    v3 v4  
    2727EDIT: Jeroen was just faster. May I however propose to use my suggestion instead if you don't mind? The =* operator should be more safe with i.e. misspellings in the values (or if more values are added later). And it's simpler ;)
    2828
    29 If not, I would recommend to change the patch by Jeroenhoek to have [parking:orientation=X][orientation][orientation!=X], rather than explicitly listing the 3 values hardcoded in every line. Also, the 1, 2 and 3 from the warning should be removed, probably leftovers from debugging? Lastly, good to suggest what to use instead in the message with number 3 (note: you can use multiple suggestAlternative, as you can see in my suggestion).
     29If not, I would recommend to change the patch by Jeroenhoek to have [parking:orientation=X][orientation][orientation!=X], rather than explicitly listing the 3 values hardcoded in every line. Also, the 1, 2 and 3 from the warning text should be removed, probably leftovers from debugging? Lastly, good to suggest what to use instead in the message with number 3 (note: you can use multiple suggestAlternative, as you can see in my suggestion).