Improve ways & data layer tool softlock

[grzegorz.piwonski@…]

What steps will reproduce the problem?

1. Use tab to hide the right hand side palette.
2. While the palette is hidden use shift + s shortcut to toggle the OSM data layer (off then on again).
3. Press "s" to enable select mode and attempt to select data on the data layer (in this case a highway).

What is the expected result?

Highway is selected.

What happens instead?

Prompted to update 'improve way' plugin (An unexpected exception occurred that may have come from the 'ImproveWay' plug-in.). If an attempt is made to update then prompted to report a bug. JOSM must be restarted to continue mapping.

Please provide any additional information below. Attach a screenshot if possible.

Once this bug occurs selecting any of the mapping tools from the upper half of the left side palette (select, laso, draw nodes etc.) other than improve way will result in a pop up prompting to update, disable or keep plgin. If the plugin is disabled, and JOSM has not been restarted the bug will persist and when selecting a tool a user will no longer be prompted to update the plugin but will be prompted to report a bug.

The right side palette continues to function and displays tag data for the object the cursor is hovering over. I am unaware if this bug prevents uploads.

Revision:18721
Build-Date:2023-05-03 12:38:30

Identification: JOSM/1.5 (18721 en_GB) Windows 10 64-Bit
OS Build number: Windows 10 Home 2009 (19045)
Memory Usage: 1072 MB / 2026 MB (399 MB allocated, but free)
Java version: 17.0.7+7-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: en_GB
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18721, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]
Dataset consistency test: No problems found

Plugins:
+ BuildingGeneralization (36)
+ CustomizePublicTransportStop (35976)
+ FastDraw (36057)
+ ImproveWay (32)
+ MakeParallel (v1.1.0)
+ PolygonCutOut (v0.7.3)
+ Relation.Validation.Plugin (1.0.1)
+ RelationDissolve (0.2.0)
+ Review.Changes (1.0.5)
+ ShapeTools (1250)
+ SimplifyArea (35978)
+ apache-commons (36034)
+ apache-http (35924)
+ areaselector (1652822522)
+ austriaaddresshelper (master-4e80dc2e4261d321150187f4951684ad97342d5e)
+ auto_tools (81)
+ buildings_tools (36011)
+ centernode (v1.0.4)
+ changeset-viewer (0.0.6)
+ changessum (v0.1.1)
+ contourmerge (v0.1.9)
+ ejml (35924)
+ gcsenabler-v0.0.1 (v0.0.1)
+ gpsblam (35893)
+ graphview (36011)
+ gridify (1606242219)
+ imagery_offset_db (35978)
+ jna (36005)
+ log4j (36034)
+ mapathoner (1.4.3)
+ mapwithai (794)
+ markseen (14)
+ measurement (35978)
+ merge-overlap (35893)
+ movemembership (1.0.0)
+ public_transport (36011)
+ reltoolbox (35976)
+ reverter (36043)
+ rex (53)
+ shrinkwrap (v1.0.4)
+ splinex (35936)
+ terracer (35978)
+ todo (123)
+ tofix (490)
+ undelete (36011)
+ utilsplugin2 (36011)
+ waydownloader (36011)

Tagging presets:
+ <josm.pref>/EasyPresets.xml

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/MapWithAI&zip=1

Last errors/warnings:
- 33855.393 E: Error in layer change listener: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.
- 33880.417 E: Error in layer change listener: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.
- 33883.965 E: Error in layer change listener: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.
- 34085.729 E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.
- 34092.975 W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- 34105.759 E: Failed to parse plug-in list document from site 'https://github.com'. Skipping site. Exception was: org.openstreetmap.josm.plugins.PluginListParseException: java.io.IOException: Illegal entry in plugin list. 
- 34105.761 E: org.openstreetmap.josm.plugins.PluginListParseException: java.io.IOException: Illegal entry in plugin list.. Cause: java.io.IOException: Illegal entry in plugin list.
- 34105.773 W: Failed to scan file 'site-github.com-.txt' for plugin information. Skipping.
- 34105.775 E: org.openstreetmap.josm.plugins.PluginListParseException: java.io.IOException: Illegal entry in plugin list.. Cause: java.io.IOException: Illegal entry in plugin list.
- 34106.481 E: Handled by bug report queue: java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.



=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (23) of main
java.lang.IllegalArgumentException: Listener org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction@d40ab66 (instance of org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction) was not registered before or already removed.
	at org.openstreetmap.josm.tools.ListenerList.failRemove(ListenerList.java:137)
	at org.openstreetmap.josm.tools.ListenerList.removeListener(ListenerList.java:131)
	at org.openstreetmap.josm.data.Preferences.removePreferenceChangeListener(Preferences.java:261)
	at org.openstreetmap.josm.actions.mapmode.MapMode.exitMode(MapMode.java:99)
	at org.openstreetmap.josm.plugins.improveway.ImproveWayAccuracyAction.exitMode(ImproveWayAccuracyAction.java:241)
	at org.openstreetmap.josm.gui.MapFrame.selectMapMode(MapFrame.java:498)
	at org.openstreetmap.josm.gui.MapFrame.selectMapMode(MapFrame.java:475)
	at org.openstreetmap.josm.actions.mapmode.MapMode.actionPerformed(MapMode.java:128)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBinding(Unknown Source)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(Unknown Source)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyBindings(Unknown Source)
	at java.desktop/javax.swing.JComponent.processKeyEvent(Unknown Source)
	at java.desktop/java.awt.Component.processEvent(Unknown Source)
	at java.desktop/java.awt.Container.processEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.Component.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$5.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)

[grzegorz.piwonski@…]

A screenshot of JOSM with red highlights showing contradictory data while it is in this bugged state.

[skyper]

Cannot reproduce on Debian.