Changes between Initial Version and Version 1 of Ticket #22727, comment 7


Ignore:
Timestamp:
2023-03-27T16:46:46+02:00 (3 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #22727, comment 7

    initial v1  
    55}}}
    66
    7 The whole point of the `boolean finishedAddingButtons` was to keep `setVisible` from being called until everything was ready. That is why it (still) needs the other `lock`/`unlock` calls.
     7The whole point of the `boolean finishedAddingButtons` was to keep specific parts of `setVisible` from being called until everything was ready. That is why it (still) needs the other `lock`/`unlock` calls.
    88
    99So that line of code ''should be'' called without any locks, as the `setVisible` call does a lock internally, which should prevent infinite recursion (due to the `!this.finishedAddingButtons.isLocked()` check).