Changes between Initial Version and Version 1 of Ticket #22614, comment 15


Ignore:
Timestamp:
2023-01-18T11:36:43+01:00 (3 years ago)
Author:
GerdP

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22614, comment 15

    initial v1  
    11@all:
    2 I don't see a way to handle overlapping way segments with the current implementation in `NodePair` and `NodeGraph` which are also used in some plugins. These classes are designed to handle overlapping segments as equal, therefore it is not possible to build a path containing overlapping segments (`opendata`, `merge-overlap`). Only the code in `CombineWayAction.joinWithMultipolygonCode(Collection<Way> ways)` allows this and I didn't really intend this, it was just a side effect.
     2I don't see a way to handle overlapping way segments with the current implementation in `NodePair` and `NodeGraph` which are also used in some plugins (`opendata`, `merge-overlap`). These classes are designed to handle overlapping segments as equal, therefore it is not possible to build a path containing overlapping segments . Only the code in `CombineWayAction.joinWithMultipolygonCode(Collection<Way> ways)` allows this and I didn't really intend this, it was just a side effect.
    33Question is if I can simply remove that code so that `CombineWayAction` never combines ways with overlapping segments? It would allow to remove a lot of code.
    44The alternative would be to write new classes and unit tests with different data structures, maybe with settings so that the user can decide wether actions should refuse to create invalid OSM data or not.