Changes between Initial Version and Version 1 of Ticket #22534, comment 5


Ignore:
Timestamp:
2022-11-29T14:34:41+01:00 (3 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #22534, comment 5

    initial v1  
    22
    33For 09-no-java-8.patch, it should be unnecessary due to [source:trunk/build.xml@18587:80,220#L220] (we compile with `--release 8`). I didn't see any modification to the `java.lang.version` in 00-build.patch. Docs indicate that Java 17 should compile bytecode ''with the appropriate method calls'' for Java 8. But we are planning on dropping Java 8 support soon, so I'm not going to complain too much.
    4 
    5 I get why you are removing all ivy usage in the build.xml file, but I don't know why you are commenting out a lot of the code (specifically the mrjar stuff, even though we aren't currently using it).
    64
    75> If you're happy to receive tickets for issues that may be caused by downstream changes, I'll happily drop the 'Report bug' changes to have it use Trac again.