building:level -> building:levels

[marc_marc]

What steps will reproduce the problem?

1. load ​https://www.openstreetmap.org/way/91895332 (building=yes + building:level=1
2. run the validator

What is the expected result?

warning about the common (10k global) typo building:levels

What happens instead?

nothing

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2022-10-26 23:39:34 +0200 (Wed, 26 Oct 2022)
Build-Date:2022-10-27 01:30:57
Revision:18582
Relative:URL: ^/trunk

Identification: JOSM/1.5 (18582 fr) Linux CentOS Linux release 7.9.2009 (Core)
Memory Usage: 539 MB / 1717 MB (96 MB allocated, but free)
Java version: 1.8.0_352-b08, Red Hat, Inc., OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1600×900 (scaling 1.00×1.00)
Maximum Screen Size: 1600×900
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: fr.utf8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: fr
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: GNOME-Classic:GNOME
Java package: java-1.8.0-openjdk:x86_64-1.8.0.352.b08
WebStart package: icedtea-web:x86_64-1.7.1
VM arguments: [-Dicedtea-web.bin.name=javaws.itweb, -Dicedtea-web.bin.location=/usr/bin/javaws.itweb]
Dataset consistency test: No problems found

Plugins:
+ ImproveOsm (232)
+ Mapillary (2.0.1)
+ apache-commons (36003)
+ apache-http (35924)
+ areaselector
+ austriaaddresshelper (1597341117)
+ cadastre-fr (36021)
+ conflation (0.6.9)
+ continuosDownload (105)
+ ejml (35924)
+ geotools (36028)
+ jackson (36006)
+ jaxb (35952)
+ jna (36005)
+ jts (36004)
+ log4j (36007)
+ opendata (36025)
+ pt_assistant (1ff2e15)
+ reverter (36011)
+ scripting
+ todo (30306)
+ utilsplugin2 (36011)
+ wikipedia (605)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Leaftype&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Light_sources&zip=1
+ https://raw.github<user.name>content.com/Heiner-Sch/JOSM-preset-trees-Europe/master/JOSM-Preset_Trees.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/BENELUX&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/MountainbikeTrails&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/contact(socialnetworks_IMs)&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/geoimage.at&zip=1
+ https://github.com/Jungle-Bus/josm-presets/raw/gh-pages/jungle-stops/Preset_Jungle-Bus.zip
+ https://josm.openstreetmap.de/josmfile?page=Presets/MobilePhoneBaseStations&zip=1
+ https://raw.github<user.name>content.com/osmlab/name-suggestion-index/main/dist/presets/nsi-josm-presets.min.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1
+ https://raw.github<user.name>content.com/species/josm-preset-wheelchair/master/sidewalks_kerbs.xml
+ https://osmtools.de/josm/steps.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Trees&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/WifiHotspots&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Presets/Wikidata&zip=1

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Styles/Landcover&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip
+ https://josm.openstreetmap.de/josmfile?page=Rules/KeepRight&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/FranceSpecificRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SuspiciousSwimming_Pool&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/SourceObjectTag&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/QAToolInspiredValidations&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/IndoorRules&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingOpeningHours&zip=1
+ https://raw.github<user.name>content.com/stefan-a-bauer/josm-validators/master/mtb.validator.mapcss
+ https://www.openrailwaymap.org/validator/openrailwaymap.validator.mapcss
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/Pictures&zip=1
+ https://josm.openstreetmap.de/josmfile?page=Rules/MissingWeekdays&zip=1
+ https://raw.github<user.name>content.com/osmlu/josm-validator-luxembourg/master/Luxembourg-Specific-Rules.validator.mapcss
+ https://raw.github<user.name>content.com/OpenNauticalChart/josm/master/Seamark.validator.mapcss

Last errors/warnings:
- 00025.143 W: Le greffon scripting nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00025.143 W: Le greffon areaselector nécessite la version Java 11. La version actuelle de Java est 8. Vous devez mettre à jour Java pour utiliser ce greffon.
- 00039.870 E: Impossible de trouver l'image "bus.png"

[taylor.smock]

Looking at the chronology for ​taginfo:keys/building:level, it looks like some mass edits took place that accidentally used building:level instead of building:levels.

$ curl 'https://taginfo.openstreetmap.org/api/4/keys/all' | jq '.data[] | select(.key == "building:level")'
{
  "key": "building:level",
  "count_all": 10422,
  "count_all_fraction": 0,
  "count_nodes": 536,
  "count_nodes_fraction": 0,
  "count_ways": 9867,
  "count_ways_fraction": 0,
  "count_relations": 19,
  "count_relations_fraction": 0,
  "values_all": 52,
  "users_all": 337,
  "in_wiki": true,
  "projects": 1
}

The users_all is who touched the object last, not who edited the object. I'm looking into the distinct users who added the tag, but I'm waiting on the full history planet download (110 GB, est. 5 hours to completion).

---

EDIT:

Using ​osm-tag-csv-history with the current ​full history planet, the total number of users who added building:level is 1359 (over all history, 216 over last two years), of which 360 added building:level more than 10 times.

In the past two years, 72% of the added building:level tags were produced by 10 users, 21 users produced 88% of the tags over the past two years, and 65 users produced 96% of the tags over the past two years.

[Klumbumbus]

In 18642/josm:

fix #22481 - Deprecate building:level in favor of building:levels

[anonymous]

The validation results window now shows the following text for a building tagged with building:level=3: "deprecated tagging - building:levels is deprecated, use building:levels instead". Note that this text contains building:levels (with a trailing s) twice, which does not seem correct.

[Klumbumbus]

That was a mistake, of cause. Thanks for the hint!

[Klumbumbus]

In 18647/josm:

see #22481 - fix building:level validator message