[PATCH][RFC] Replace Utils.isStripEmpty with Utils.isBlank in AbstractPrimitive#put

[taylor.smock]

I've been doing some profiling with Vector tiles, and I've noticed that makes a significant number of allocations.

Looking at the profiler output, it looks like Utils.isBlank effectively gets optimized away (tested on Java 8/17). Does anyone know of a reason to keep Utils.isStripEmpty?

src/org/openstreetmap/josm/data/osm/AbstractPrimitive.java

@@ -584 +584 @@
     @Override
     public void put(String key, String value) {
         Map<String, String> originalKeys = getKeys();
-        if (key == null || Utils.isStripEmpty(key))
+        if (key == null || Utils.isBlank(key))
             return;
         else if (value == null) {
             remove(key);

Utils#isStripEmpty, Java 8

Allocations:

• Utils#isStripEmpty: 112 MB
• Arrays#copyOf: 57 MB
• AbstractPrimitive#getKeys: 25 MB
• String[]: 4 MB

Utils#isBlank, Java 8

Allocations:

• Arrays#copyOf: 61 MB
• AbstractPrimitive#getKeys: 3.5 MB
• String[]: 2.3 MB

Utils#isBlank, Java 17

Allocations:

• Arrays#copyOf: 21 MB
• AbstractPrimitive#getKeys: 43 MB
• String[]: 12 MB

There is a bit of jitter, but the primary cost of AbstractPrimitive#put is from Utils#isStripEmpty.

[taylor.smock]

Utils#isStripEmpty (Java 8)

[taylor.smock]

Utils#isBlank (Java 17)

[taylor.smock]

Utils#isBlank (Java 8)