[WIP patch] Deprecate vending=parcel_pickup

[overflorian]

Hi,
A new tag just ​has been approved: ​Tag:amenity=parcel_locker and describes a parcel locker.
It replaces previously used (and now deprecated) amenity=vending_machine + vending=parcel_pickup

I propose to:

• While a amenity=vending_machine is created, stop proposing the associated preset vending=parcel_pickup
• Create a new dedicated preset for amenity=parcel_locker
• Change the validator accordingly

Thanks

PS: deprecation follow-up (including similar requests to other tools) is available on this wiki page: ​https://wiki.openstreetmap.org/wiki/Tag:vending%3Dparcel_pickup#Deprecation_follow-up

[gaben]

A preset is already available for download, see Presets/ParcelLockers.

[aceman]

Thanks, but that preset offers also undocumented tags like 'parcel_locker=', or mixes name and number into a single tag 'ref='.

Anyway, JOSM should have this built in, because the lockers are very popular in the wild. The real extent in OSM is unknown, as many have been tagged as amenity=vending_machine as that was the method at the time.

[gaben]

The icon from the above preset would do it for JOSM?

[gaben]

Please try out the provided patch.

The preset structure is not appealing for me, but this is the best I could came up with.

Edit: the icon is from the above preset (​here), but slightly modified by me.

[gaben]

initial patch

[gaben]

add missing commas, change mapcss rule

[gaben]

The messages still not working as one would expect, but it's JOSM's limitation. With regex, sublist and probably more, the {*.key} property cannot read out.

One possible solution is duplicating rules:

*[amenity=vending][vending=parcel_mail_in],
*[amenity=vending][vending=parcel_pickup],
*[amenity=vending][vending=parcel_mail_in;parcel_pickup],
*[amenity=vending][vending=parcel_pickup;parcel_mail_in] { ... }

but it isn't elegant ...and doesn't work. I'm out of ideas. Probably a new custom message is needed.

[skyper]

Some remarks:

• I guess the icon needs more colors/contrast. Only one color does not work well, regarding different LaFs and backgrounds.
• The style should support areas and not only nodes.
• The validator rule does not work so far, as parcel_mail_in and/or parcel_pickup need to be preserved as keys. Maybe, we need several rules for different cases.

[gaben]

• Yes, a white bg would do it, like the hunting stand's icon.
• The wiki page was modified since then, allowing areas as well, thanks for noticing.
• What do you mean? It is preserved by the patch, only ignoring vending=parcel_mail_in/parcel_pickup.

[skyper]

• A background might work, but actually I am not convinced about the icon and its recognition.
• The wiki was wrong as prior use and the proposal included areas.
• No, I would expect to add parcel_pickup=yes if the key is not present and vending=parcel_pickup is removed. Same for parcel_mail_in=*.

[kubahaha]

How is it going? Since amenity=parcel_locker is added even to default carto style

[gaben]

I've created the base patch, and looking at the wiki page we got a new icon since then.

@skyper can you work on this or should I proceed with the patch?