Windows: Icon of link on Desktop and Start menu is in "%APPDATA%\Microsoft\Installer\..."

[zocker22@…]

What steps will reproduce the problem?

1. Install or update Windows version
2. Take a look at preferences of the JOSM link on Desktop and Start Menu (Link -> Symbol)

What is the expected result?

I think the best way would be a constant path to the icon. I'd suggest

"C:\Users\USERNAME\AppData\Local\JOSM\JOSM.ico" / "%USERPROFILE%\AppData\Local\JOSM\JOSM.ico"
"C:\Users\USERNAME\AppData\Local\JOSM\HWConsole.ico" / "%USERPROFILE%\AppData\Local\JOSM\HWConsole.ico"

since they are already there.

What happens instead?

The path of the icon is "%APPDATA%\Microsoft\Installer\...". This is a problem because "..." changes with every JOSM update. Currently it's "%APPDATA%\Microsoft\Installer\{CD6B04FD-BEC5-3E36-913A-362C2684FCB2}\icon154464376".
When you moved the link somewhere else (e.g. custom folder in Start Menu) you need to replace it after every JOSM update with the link that has been created by the new JOSM installer. Else the link won't have an icon anymore.

Another small thing: the installer creates a folder called "unknown" in Start Menu (or something like that, I'm not sure). I think a folder called "JOSM" would be better.

Please provide any additional information below. Attach a screenshot if possible.

Revision:18303
Build-Date:2021-11-01 22:53:13

Identification: JOSM/1.5 (18303 de) Windows 7 64-Bit
OS Build number: Windows 7 Ultimate (7601)
Memory Usage: 296 MB / 8184 MB (81 MB allocated, but free)
Java version: 17.0.1+12-LTS, Azul Systems, Inc., OpenJDK 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→32×32, 32×32→32×32
System property file.encoding: Cp1252
System property sun.jnu.encoding: Cp1252
Locale info: de_DE
Numbers with default locale: 1234567890 -> 1234567890
VM arguments: [-Djpackage.app-version=1.5.18303, --add-modules=java.scripting,java.sql,javafx.controls,javafx.media,javafx.swing,javafx.web, --add-exports=java.base/sun.security.action=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.plugins.jpeg=ALL-UNNAMED, --add-exports=java.desktop/com.sun.imageio.spi=ALL-UNNAMED, --add-opens=java.base/java.lang=ALL-UNNAMED, --add-opens=java.base/java.nio=ALL-UNNAMED, --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED, --add-opens=java.base/jdk.internal.ref=ALL-UNNAMED, --add-opens=java.desktop/javax.imageio.spi=ALL-UNNAMED, --add-opens=java.desktop/javax.swing.text.html=ALL-UNNAMED, --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED, -Djpackage.app-path=%UserProfile%\AppData\Local\JOSM\JOSM.exe]

Plugins:
+ BuildingGeneralization (36)
+ buildings_tools (35823)
+ imagery_offset_db (35640)
+ pbf (35825)
+ poly (35640)
+ reverter (35732)
+ turnrestrictions (35640)
+ undelete (35640)
+ utilsplugin2 (35842)

Last errors/warnings:
- 00000.445 W: extended font config - overriding 'filename.Mongolian_Baiti=monbaiti.ttf' with 'MONBAITI.TTF'
- 00000.446 W: extended font config - overriding 'filename.Kalinga=kalinga.ttf' with 'KALINGA.TTF'
- 00000.446 W: extended font config - overriding 'filename.Iskoola_Pota=iskpota.ttf' with 'ISKPOTA.TTF'
- 00000.446 W: extended font config - overriding 'filename.Shruti=shruti.ttf' with 'SHRUTI.TTF'
- 00000.447 W: extended font config - overriding 'filename.Raavi=raavi.ttf' with 'RAAVI.TTF'
- 00000.447 W: extended font config - overriding 'filename.Gautami=gautami.ttf' with 'GAUTAMI.TTF'
- 00000.448 W: extended font config - overriding 'filename.Vrinda=vrinda.ttf' with 'VRINDA.TTF'
- 00000.448 W: extended font config - overriding 'filename.Kartika=kartika.ttf' with 'KARTIKA.TTF'
- 00000.449 W: extended font config - overriding 'filename.Latha=latha.ttf' with 'LATHA.TTF'
- 00001.382 E: java.security.KeyStoreException: Windows-ROOT not found. Ursache: java.security.NoSuchAlgorithmException: Windows-ROOT KeyStore not available