Changes between Initial Version and Version 1 of Ticket #21482, comment 5


Ignore:
Timestamp:
2021-10-30T19:41:19+02:00 (4 years ago)
Author:
Klumbumbus

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21482, comment 5

    initial v1  
    55It does or do you have a counter example? (In #21143 there was a problem with fonts different than Droid Sans. We removed the unused font properties from the uncleaned files to get a better overview which icons need to be actually changed. The cleaned code from health\clinic.svg before r18083 was: `<svg height="16" viewBox="0 0 16 16" width="16" xmlns="http://www.w3.org/2000/svg"><g transform="translate(0 -1036.3621)"><rect fill="#fff" height="16.000046" rx="2.000002" width="16.000008" y="1036.3621"/><g fill="#3771c8" transform="matrix(.85716634 0 0 .85716634 2.859681 150.89059)"><path d="m7.8178461 1041.8617c-.8260795 0-1.4905882.7755-1.4905882 1.7382v6.9336c-.013155 1.0862 1.3917706 1.0862 1.3785772 0v-5.722h.710423v6.5506h4.4223349v-6.5506h.78274v5.722c-.0133 1.0862 1.391832 1.0862 1.378576 0v-6.9342c0-.9625-.665741-1.7381-1.491821-1.7381h-5.6902419z"/><ellipse cx="10.663416" cy="1039.2753" rx="1.91276" ry="1.912785"/></g><path d="m6.0000019 1042.3621h3.000001v-2h-3.000001v-3h-2.0000009v3h-3.000001v2h3.000001v3h2.0000009z" fill="#c00" fill-rule="evenodd"/></g></svg>`)
    66> Still, unused elements should still be removed, in my eyes.
    7 Yes unused elements or too much details could be removed. Ususally the uncleaned svgs have a file size below 30KB. If it is larger it could be checked for useless details. See e.g. https://openclipart.org/detail/312240/forklift. If you look at the windshield in inkscape it has unnedded nodes on a nearly straight line. Also the barcode on the box will not be visible in JOSM. These are things which can't be "optimized" automatically by the svgcleaner. When thinking about unnedded details keep in mind that icons will be displayed bigger than 16px, e.g. in the tool bar on hidpi screen I can imagine 64px sizes or even bigger.
     7Yes unused elements or too much details could be removed. Ususally the uncleaned svgs have a file size below 30KB. If it is larger it could be checked for useless details. See e.g. https://openclipart.org/detail/312240/forklift. If you look at the windshield or the yellow box in inkscape it has unnedded nodes on a nearly straight line. Also the barcode on the box will not be visible in JOSM. These are things which can't be "optimized" automatically by the svgcleaner. When thinking about unnedded details keep in mind that icons will be displayed bigger than 16px, e.g. in the tool bar on hidpi screen I can imagine 64px sizes or even bigger.
    88
    99However manual editing the svg code by removing default values or comment sections or similar, i.e. everything which will be removed automatically by the svgcleaner is not worth the effort.