Changes between Initial Version and Version 1 of Ticket #21476, comment 11


Ignore:
Timestamp:
2021-11-02T18:58:53+01:00 (4 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21476, comment 11

    initial v1  
    11I've gone ahead and done a PR request on github ( https://github.com/JOSM/josm/pull/78 ) for attachment:21476.ci_fix.2.patch . I intended to overwrite the other patch (attachment:21476.ci_fix.patch), as it wasn't up to date.
     2
     3EDIT: And CI passed on GitHub. Except for "Java 8 on ubuntu-latest", which failed with the following:
     4{{{
     5Testcase: org.openstreetmap.josm.gui.preferences.plugin.PluginPreferenceTest
     6Test: testBuildDownloadSummary() took 1 sec(s)
     7Test: testNotifyDownloadResults() took 1 sec(s)
     8Test: testPluginPreference() took 1 sec(s)
     9Test: testAddGui() took 1 sec(s) FAILED: null
     10java.util.ConcurrentModificationException
     11        at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferencesModel.getSelectedPlugins(PluginPreferencesModel.java:143)
     12        at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferencesModel.getSelectedPluginNames(PluginPreferencesModel.java:152)
     13        at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferencesModel.isActivePluginsChanged(PluginPreferencesModel.java:323)
     14        at org.openstreetmap.josm.gui.preferences.plugin.PluginPreference.ok(PluginPreference.java:299)
     15        at org.openstreetmap.josm.gui.preferences.PreferencesTestUtils.doTestPreferenceSettingAddGui(PreferencesTestUtils.java:31)
     16        at org.openstreetmap.josm.gui.preferences.plugin.PluginPreferenceTest.testAddGui(PluginPreferenceTest.java:106)
     17}}}