Changes between Initial Version and Version 1 of Ticket #21423, comment 17


Ignore:
Timestamp:
2022-07-25T16:56:53+02:00 (3 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21423, comment 17

    initial v1  
    11An additional quick comment on attachment:21423.patch:
    22* I did not add a check at test runtime to ensure that tests only ever use a declared error code. This is because we are running tests in three separate areas :
    3  * `ValidateAction`
    4  * `ValidatorCLI`
    5  * `ValidateUploadHook`
     3 * [source:trunk/src/org/openstreetmap/josm/actions/ValidateAction.java@18523:55-83#L55 ValidateAction#doValidate]
     4 * [source:trunk/src/org/openstreetmap/josm/data/validation/ValidatorCLI.java@18523:243-284#L243 ValidatorCLI#processFile]
     5 * [source:trunk/src/org/openstreetmap/josm/actions/upload/ValidateUploadHook.java@18523:50-98#L50 ValidateUploadHook#checkUpload]
    66
    77I'm looking at creating a new method in `OsmValidator` to run enabled tests so that we aren't doing (effectively) the same thing in three different places, and that is where I'll add the check to ensure all test errors use a declared error code.