Opened 4 years ago

Last modified 4 years ago

#21344 closed enhancement

[PATCH] Allow opening a directory tree of pictures in JOSM — at Version 7

Reported by: marcello@… Owned by: team
Priority: normal Milestone: 21.10
Component: Core Version:
Keywords: Cc:

Description (last modified by taylor.smock)

JOSM should allow users to open multiple directories of images. The attached patch does affect other file types.

Old bug report description

Mapillary "Import Pictures" does not honor exif orientation
When importing images with File | Import Pictures | All Images in a Directory all portrait images are rotated. Importing the same pictures with File | Open ... all portrait pictures are right.

Change History (11)

by marcello@…, 4 years ago

comment:1 by taylor.smock, 4 years ago

As an FYI, the import functionality in the Mapillary plugin is a candidate for removal.

The only reason it still exists is for 360 image support, which I've been working on moving into JOSM core. Once that happens, the import functionality will be removed.

comment:2 by marcello@…, 4 years ago

That's bad because it is the only way to import a directory tree of pictures into JOSM. File | Open ... does only one directory at a time. I guess that's another ticket then.

comment:3 by taylor.smock, 4 years ago

My long term intent is to move as much stuff as possible into JOSM core that is not directly related to Mapillary (as in, it requires the Mapillary API) so that other plugins (e.g., MS StreetSide, KartaView, etc.) can reuse code, so if there is something in Mapillary not directly related to the Mapillary API, please let me know so I can look into moving it to JOSM core.

Last edited 4 years ago by taylor.smock (previous) (diff)

in reply to:  2 comment:4 by taylor.smock, 4 years ago

Replying to marcello@…:

That's bad because it is the only way to import a directory tree of pictures into JOSM. File | Open ... does only one directory at a time. I guess that's another ticket then.

It turns out to be a fairly simple change.

The only problem is that the native file choosers may not support it, so we get the uglier Java Swing File picker.

Java Swing File PickerMac OS X Native File Picker

Last edited 4 years ago by taylor.smock (previous) (diff)

by taylor.smock, 4 years ago

Attachment: 21344.patch added

Allow directories of images or other files to be opened in JOSM

by taylor.smock, 4 years ago

Java Swing File Picker

by taylor.smock, 4 years ago

Mac OS X Native File Picker

comment:5 by taylor.smock, 4 years ago

@marcello: I'm OK with moving to the uglier, but more functional Java Swing Picker for JOSM. Will that work for you?

Last edited 4 years ago by taylor.smock (previous) (diff)

comment:6 by marcello@…, 4 years ago

that's ok with me

comment:7 by taylor.smock, 4 years ago

Component: Plugin mapillaryCore
Description: modified (diff)
Keywords: mapillary exif orientation removed
Owner: changed from taylor.smock to team
Summary: Mapillary "Import Pictures" does not honor exif orientation[PATCH] Allow opening a directory tree of pictures in JOSM
Type: defectenhancement
Note: See TracTickets for help on using tickets.