Opened 4 years ago
Last modified 4 years ago
#21332 new enhancement
False positive from RelationChecker? — at Version 2
Reported by: | zstadler | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core validator | Version: | tested |
Keywords: | template_report relation member role validation | Cc: |
Description (last modified by )
What steps will reproduce the problem?
- Click "File -> Download object..." -> relation 3472179 + download referrers + download relation members
- Click "Validation" -> check there are no "Role verification problem" warnings.
- Click "Download" -> use current map extent and download all OSM data
- Click "Validation" again -> find a new "Role verification problem" for relation 3472179 - "Haifa Trail - Downtown".
- Confirm that all members of this route relation have a "highway" tag using the OSM website or this Overpass-Turbo query.
What is the expected result?
- When a "Role verification problem" warning is found, it should include both two objects involved: the parent relation and the member in order to allow examination. This would be similar to other warning, such as highway crossings.
- If the warning in step 4 is valid, it should have been presented in step 2.
- Walking and hiking relations may have members that are relations. If the warning in step 4 is related to relation 13207704 "Haifa Trail" and its member relation 3472179 "Haifa Trail - Downtown", then the rule should be restricted to members that are way elements. See the OSM wiki on Walking Routes.
What happens instead?
- A new warning is added in step 4 above:
route("Haifa Trail - Downtown", 62 members) Role verification problem Role of relation member does not match template expression 'highway || route=ferry' in preset Hiking Route Test: Relation checker Java: org.openstreetmap.josm.data.validation.tests.RelationChecker
- It is not clear why this warning is given.
- It is not clear why the warning was not given in step 2.
Please provide any additional information below. Attach a screenshot if possible.
URL:https://josm.openstreetmap.de/svn/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2021-09-03 03:12:33 +0200 (Fri, 03 Sep 2021) Build-Date:2021-09-03 01:31:19 Revision:18193 Relative:URL: ^/trunk Identification: JOSM/1.5 (18193 en_GB) Windows 10 64-Bit OS Build number: Windows 10 Pro 2009 (22000) Memory Usage: 599 MB / 3612 MB (86 MB allocated, but free) Java version: 1.8.0_301-b09, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel Screen: \Display0 1920×1080 (scaling 1.00×1.00) Maximum Screen Size: 1920×1080 Best cursor sizes: 16×16→32×32, 32×32→32×32 System property file.encoding: Cp1252 System property sun.jnu.encoding: Cp1252 Locale info: en_GB Numbers with default locale: 1234567890 -> 1234567890 VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=%UserProfile%\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-708180f6, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=58381, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe] Dataset consistency test: No problems found Plugins: + apache-commons (35524) + contourmerge (v0.1.8) + ejml (35458) + geotools (35458) + importvec (35567) + jaxb (35543) + jts (35458) + opendata (35803) + reverter (35732) + undelete (35640) + utilsplugin2 (35792) Last errors/warnings: - 01070.374 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico' - 01070.377 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico' - 02233.457 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico' - 02233.459 E: Failed to locate image 'https://israelhiking.osm.org.il/content/favicons/favicon.ico'
Change History (4)
by , 4 years ago
Attachment: | JOSM_RelationChecker.png added |
---|
comment:2 by , 4 years ago
Component: | Core → Internal preset |
---|---|
Description: | modified (diff) |
Keywords: | relation member role validation added |
Version: | → tested |
by , 4 years ago
Attachment: | relationMembers.png added |
---|
Note:
See TracTickets
for help on using tickets.
screenshot