Opened 4 years ago

Last modified 4 years ago

#21305 closed defect

[PATCH] Fix typo in MultiFetchServerObjectReaderTest.java — at Initial Version

Reported by: taylor.smock Owned by: team
Priority: minor Milestone: 21.10
Component: Unit tests Version: latest
Keywords: test Cc: Gubaer

Description

trunk/test/functional/org/openstreetmap/josm/io/MultiFetchServerObjectReaderTest.java@18202:335-335#L335 looks like it should be assertEquals(n1.get("name"), n2.get("name")) (note the first n goes from 2 -> 1).

Gubaer touched it last in 2009, and I doubt anyone would remember something like that 12 years later. That being said, I cannot think of a good reason for it.

I found this while working on #21139, but I haven't been able to successfully run the functional tests on JOSM master (ant -Djava.awt.headless=true -Dosm.username='user@example.com' -Dosm.password='some-random-password' test-clean test '-Ddefault-junit-includes=**/josm/io/MultiFetchServerObjectReader*'). I've got some changes for #21139 (not yet committed) that have allowed me to run the tests, but most of the MultiFetchServerObjectReader tests are not passing yet there.

Change History (1)

by taylor.smock, 4 years ago

Attachment: 21305.patch added

Fix variable typo

Note: See TracTickets for help on using tickets.