Mapillary plugin

[anonymous]

What steps will reproduce the problem?

1. Clicking on a mapillary picture

What is the expected result?

showing the picture

What happens instead?

this error - again and again

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-07-03 21:56:57 +0200 (Sat, 03 Jul 2021)
Revision:17947
Build-Date:2021-07-04 01:30:58
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (17947 de) Linux Ubuntu 21.04
Memory Usage: 448 MB / 3072 MB (143 MB allocated, but free)
Java version: 15.0.3+3-Ubuntu-1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1080 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1080
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: de_AT.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: de_AT
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: KDE
Java ATK Wrapper package: libatk-wrapper-java:all-0.38.0-2ubuntu2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ Mapillary (2.0.0-alpha.24-dirty)
+ apache-commons (35524)
+ apache-http (35589)
+ austriaaddresshelper (1597341117)
+ buildings_tools (35756)
+ changeset-viewer (25)
+ editgpx (35562)
+ javafx-unixoid (35655)
+ jna (35662)
+ reverter (35732)
+ tageditor (35640)
+ turnlanes (35640)
+ turnlanes-tagging (288)
+ utilsplugin2 (35691)

Map paint styles:
+ https://josm.openstreetmap.de/josmfile?page=Styles/ParkingLanes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Enhanced_Lane_and_Road_Attributes&zip=1

Last errors/warnings:
- 00050.641 E: Unknown detection "void--unlabeled"
- 00050.641 E: Unknown detection "void--unlabeled"
- 00050.642 E: Unknown detection "void--unlabeled"
- 00050.642 E: Unknown detection "void--unlabeled"
- 00050.642 E: Unknown detection "void--unlabeled"
- 00050.642 E: Unknown detection "void--unlabeled"
- 00050.643 E: Unknown detection "void--unlabeled"
- 00050.643 E: Unknown detection "void--unlabeled"
- 00050.643 E: Unknown detection "void--unlabeled"
- 00050.643 E: Unknown detection "void--unlabeled"



=== REPORTED CRASH DATA ===
JsonDecoder#lambda$decodeData$0:
 - json: {"altitude":1196.3331499211,"thumb_2048_url":"https://scontent-vie1-1.xx.fbcdn.net/m1/v/t6/An_BwnSzCOm921_NSvhjagm8MOeVW8h5ChrVYGC1vJRYdBu_ZS2kVkWa0KwyghtNTHktgvcuZb8i_kFRii9R3YvNyWaJ6Aeyv9sJLkwfGh_lOZ_QZc8m21A8krQY4aO2rLpvTUIqpW3V0rAggBpqTQ?stp=s2048x1536&tp=1&ccb=9-4&oh=ae722df96dcd279eed2b1b3827ccf6fa&oe=60E97F02","captured_at":1591250711478,"compass_angle":98.136882729076,"computed_altitude":-0.38174772448838,"computed_compass_angle":51.743147699608,"computed_geometry":{"type":"Point","coordinates":[13.639708268383,47.378092877232]},"computed_rotation":[1.265118,-0.738662,0.949159],"exif_orientation":1,"geometry":{"type":"Point","coordinates":[13.639803815889,47.377939736878]},"id":"509678286853928","quality_score":0.90566037735849,"sequence":"duavtaiaevwqj2e6yfxaff","thumb_256_url":"https://scontent-vie1-1.xx.fbcdn.net/m1/v/t6/An_BwnSzCOm921_NSvhjagm8MOeVW8h5ChrVYGC1vJRYdBu_ZS2kVkWa0KwyghtNTHktgvcuZb8i_kFRii9R3YvNyWaJ6Aeyv9sJLkwfGh_lOZ_QZc8m21A8krQY4aO2rLpvTUIqpW3V0rAggBpqTQ?stp=s256x192&tp=1&ccb=9-4&oh=ba6dad541ea66d0a5b69139b8e44f26e&oe=60E97F02"}

Warning issued by: JsonDecoder#lambda$decodeData$0

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (21) of main
java.lang.IllegalStateException: Duplicate key computed_altitude (attempted merging values -0.38174772448838 and -0.38174772448838)
	at java.base/java.util.stream.Collectors.duplicateKeyException(Collectors.java:133)
	at java.base/java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180)
	at java.base/java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
	at org.openstreetmap.josm.plugins.mapillary.utils.api.JsonImageDetailsDecoder.decodeImageInfo(JsonImageDetailsDecoder.java:117)
	at org.openstreetmap.josm.plugins.mapillary.utils.api.JsonImageDetailsDecoder.decodeImageInfos(JsonImageDetailsDecoder.java:64)
	at org.openstreetmap.josm.plugins.mapillary.io.download.MapillaryDownloader.lambda$realDownloadImages$2(MapillaryDownloader.java:95)
	at org.openstreetmap.josm.plugins.mapillary.utils.api.JsonDecoder.decodeData(JsonDecoder.java:94)
	at org.openstreetmap.josm.plugins.mapillary.io.download.MapillaryDownloader.realDownloadImages(MapillaryDownloader.java:95)
	at org.openstreetmap.josm.plugins.mapillary.io.download.MapillaryDownloader.downloadImages(MapillaryDownloader.java:61)
	at org.openstreetmap.josm.plugins.mapillary.cache.MapillaryCache.lambda$prefetchImageDetails$4(MapillaryCache.java:154)
	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1429)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

[taylor.smock]

Ticket #21070 has been marked as a duplicate of this ticket.

[taylor.smock]

I wasn't able to reproduce with the supplied JSON, however, I have changed how I was setting the keys.

I have no clue how duplicate keys are being added (I wasn't able to reproduce with the json given, nor with adding a vectornode with duplicate keys, nor with adding a duplicate key to the json).

Regardless, I think I've fixed it. See ​b56c17013dd2521cd1e9bbd7b7da7578d8492925.

[skyper]

Does not work, see #21075.

[taylor.smock]

I'm pretty certain #21075 is a dupe of #21066, so the workaround may have worked.

EDIT:

The NPE is occurring in a different line of code (AKA, in a line not modified in the commit I mentioned to fix this bug), and I'm not seeing how the NPE is actually reached.