Changes between Version 1 and Version 2 of Ticket #20969, comment 5


Ignore:
Timestamp:
2021-06-24T15:15:07+02:00 (5 years ago)
Author:
Bjoeni

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #20969, comment 5

    v1 v2  
    2929
    3030~~That whole `HistoryComboBox`~~ ''(Edit: actually it's not the `HistoryComboBox` but just the way it's handled in `BasicUploadSettingsPanel`)'' is pretty messy (as per usual when trying to keep two data sources in sync). Typing something in the textbox causes the combobox to be updated and send an event back to the textbox to be updated, which then updates the combobox again (and then it stops, because nothing changes).
    31 I actually don't even understand why the combobox needs to be updated on the fly at all: In my onion the combobox should just be filled once from the preferences, and it should be sufficient to only keep the current comment in the textbox. That might also fix #20690 and should be looked at there.
     31I actually don't even understand why the combobox needs to be updated on the fly at all: In my opinion the combobox should just be filled once from the preferences, and it should be sufficient to only keep the current comment in the textbox. That might also fix #20690 and should be looked at there.
    3232
    3333But for now, the patch above should fix the issue in this ticket.