Changes between Initial Version and Version 1 of Ticket #20680, comment 5


Ignore:
Timestamp:
2021-09-27T09:43:46+02:00 (4 years ago)
Author:
GerdP

Legend:

Unmodified
Added
Removed
Modified

  • TabularUnified Ticket #20680, comment 5

    initial v1  
    11Similar changes are required in other tests which care about the geometry of ways. Do we already have a ticket for this?
    22These ones are obvious candidates:
    3 - `LongSegment`
     3- `LongSegment` (already seems to work when node is moved)
    44- `MapCssTagChecker` (but only for tests like those in geometry.mapcss)
    5 - `MultipolygonTest`
    6 - `OverlappingWays`
    7 - `RightAngleBuildingTest`
    8 - `SelfIntersectingWay`
    9 - `SharpAngles`
    10 - `UnconnectedNodes`
    11 So, it would be good to have common code for them to avoid code duplication.
    12 
     5- `MultipolygonTest` (doesn't work if existing way node is moved so that the multipolygon geometry is invalid)
     6- `OverlappingWays` (modified nodes are no problem, but a new way sharing segments with an old way)
     7- `RightAngleBuildingTest` (doesn't work if existing building node is moved)
     8- `SelfIntersectingWay` (probably no problem, moved nodes cannot trigger this error)
     9- `SharpAngles` (doesn't work if existing way node is moved to build a sharp angle)
     10- `UnconnectedNodes` (doesn't work if existing node of a highway is moved closer to an unconnected node)
     11So, it would be good to have common code for them to avoid code duplication.