Add man_made pump preset

[francois.lacombe]

Dear maintainers,

Earlier this year, pumping proposal has been reviewed and approved on osm wiki.
​https://wiki.openstreetmap.org/wiki/Proposed_features/Pumping_proposal

It reinforces tagging associated to man_made=pump and some presets could be useful to encourage mappers to use it accordingly.

Is this possible to add a preset "Pump" for man_made_pump please?
​https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dpump

Some combinations could be done with man_made=pump and could also be added to man_made=windpump, man_made=water_well or man_made=petroleum_well.

• pump_mechanism=* see values ​https://wiki.openstreetmap.org/wiki/Key:pump_mechanism
• mechanical_driver=* see values ​https://wiki.openstreetmap.org/wiki/Key:mechanical_driver
• mechanical_coupling=* see values ​https://wiki.openstreetmap.org/wiki/Key:mechanical_coupling
• handle=wheel,cross,lever,crank,button,no ​https://wiki.openstreetmap.org/wiki/Key:handle
• pressure=*
• flow_rate=*
• operator=*
• manufacturer=*

handle is already in use with pipeline=valve

Very simple validation rules apply

• when mechanical_driver=manual used, handle=* is expected.
• pump_mechanism=* requires man_made=pump, man_made=windpump, man_made=water_well or man_made=petroleum_well

Thanks in advance

[skyper]

Do you have some nice icons (.svg) ?

[francois.lacombe]

Pump icon for man_made=pump preset

[francois.lacombe]

Hi Skyper

Here is a pump icon that could be associated to man_made=pump
It is provided with a blue background that could be changed accordingly with substance=* value, just like street cabinets with street_cabinet=*

All the best

[francois.lacombe]

Keep in mind #20531 is linked to this ticket and can be processed in the same time.

Best regards

[Don-vip]

We need a pump icon and I can't find a suitable one.

​https://www.flaticon.com/free-icon/water-pump_940748 and ​https://www.flaticon.com/free-icon/water-pump_523818 are really good but I'm not sure about the license.

Any volunteer to draw a new one? :D

[Klumbumbus]

In r17028 I made one for man_made=pumping_station. As this was not so long ago we could change it and use it for man_made=pump instead. But that would require to find a new icon for man_made=pumping_station...

[francois.lacombe]

Don-Vip, Klmbumbus, didn't you guys see the beautiful one I've provided upside? :)

https://josm.openstreetmap.de/attachment/ticket/20530/eau_pompe.svg

Well, mine is a centrifugal one while Don-Vip proposed a piston (fountain) shape one, both are suitable but I'd use the fountain for man_made=water_well.
We can discuss this here.

[Klumbumbus]

Replying to francois.lacombe:

Don-Vip, Klmbumbus, didn't you guys see the beautiful one I've provided upside? :)

https://josm.openstreetmap.de/attachment/ticket/20530/eau_pompe.svg

True, thats nice. Did you create it yourself or what's the source?

[francois.lacombe]

It's mine, CC BY-SA licence :)

[Don-vip]

Ah, didn't see it at all, sorry :D It's nice, thank you!

[Don-vip]

@François if you find/make an icon for ​windpump I'm ok to add it too.

[Don-vip]

@François same for ​petroleum_well. It has been ignored in r9050 because it was unclear at the time but it's time we include it now.

[francois.lacombe]

Sorry guys, I won't have enough time to work on this shortly

I agree this would be great but will require further improvement

[francois.lacombe]

Icon for man_made=windpump

[francois.lacombe]

Icon for man_made=petroleum_well

[francois.lacombe]

Dear all

Find attached 2 missing icons, for windpump and petroluem_well.

Hope this will do the job, all the best

[skyper]

@Don-vip:
Do you take care of this or would you like to get support by a patch? Ticket is assign to yourself.

[Don-vip]

I already started to work on this, I'll do it soon.

[skyper]

Fine, I can wait and take care of other tickets then.

[francois.lacombe]

Thank you

Let me know, I'll do translation in French for next release.

[Don-vip]

I can't find enough time to finish this :( If anyone wants to do it, go. If not, I'll take it back after my holidays, in September.

[skyper]

Mmh, I did not fully understand which additional tags are suited for water_well, petroleum_well and windpump.
mechanical_drive does not work with windpump, I guess, and handle is only useful with mechanical_drive=manual (validator warning). Anything else to consider?

For the background color of pump and pumping_station I would use the same colors used for generator:source=* with power=generator.

[francois.lacombe]

Hi Skyper, thank you for the followup

Indeed only windpump has restriction on mechanical_driver.
Wells can got all pump tagging.

As handles may be installed in case of failing driver, windpumps particularly can have handles despite the driver isn't manual.
See ​https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dwindpump
I've corrected the ticket because it wasn't correct to validate handle with manual driver only. It's more handle is expected when mechanical_driver=manual is used (already the case with pipeline=valve + actuator=manual)

I understand you propose to adapt icons background, according to what tag exactly?