abandoned:building disused:building - convert to building

[mkoniecz]

disused/abandoned building is still a building, therefore it should be tagged as building=*

abandoned:shop makes sense because nonfunctional shop is no longer a shop, buildings are different.

demolished:building kept for some time (until aerials are updated) makes sense because demolished building is no longer a building.

This would also help people confused why their buildings are not processed by data consumers due to using unusual tagging scheme.

What steps will reproduce the problem?

1. Create a closed way
2. Tag it with abandoned:building / disused:building
3. Run validator

What is the expected result?

Validator proposes to convert abandoned:building=* into building=*+ abandoned=yes and disused:building=* into building=* + disused=yes

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

See ​https://taginfo.openstreetmap.org/keys/abandoned%3Abuilding#map ​https://taginfo.openstreetmap.org/keys/disused%3Abuilding#map - usage is limited to a single broken import

See ​https://taginfo.openstreetmap.org/keys/disused%3Abuilding#combinations ​https://taginfo.openstreetmap.org/keys/abandoned%3Abuilding#map - building tag is often missing

Note, this may be controversial. Some people thing that such tagging scheme is supposed to be supported (JOSM and data consumers in general are not supporting it, and AFAIK such promotors are minority)

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-07 18:58:40 +0200 (Fri, 07 Aug 2020)
Revision:16853
Build-Date:2020-08-08 01:30:49
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16853 en_GB) Linux Ubuntu 20.04.1 LTS
Memory Usage: 352 MB / 976 MB (153 MB allocated, but free)
Java version: 11.0.8+10-post-Ubuntu-0ubuntu120.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Java package: openjdk-11-jre:amd64-11.0.8+10-0ubuntu1~20.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (35500)
+ measurement (35405)
+ reverter (35499)
+ todo (30306)

Last errors/warnings:
- W: Cannot lock cache directory. Will not use disk cache
- W: Cannot start IPv4 remotecontrol server on port 8111: Address already in use (Bind failed)
- W: Cannot start IPv6 remotecontrol server on port 8111: Address already in use (Bind failed)