Changes between Initial Version and Version 3 of Ticket #19277


Ignore:
Timestamp:
2020-06-04T07:50:07+02:00 (6 years ago)
Author:
johsin18
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #19277

    • Property Keywords refactoring added
    • Property Type defect → enhancement
    • Property Summary Class GuiSizesHelper has tons of bad code → Class GuiSizesHelper should be refactored or removed

  • Ticket #19277 – Description

    initial v3  
    1 Class org.openstreetmap.josm.tools.GuiSizesHelper IMHO has tons of bad code
     1Class org.openstreetmap.josm.tools.GuiSizesHelper should be refactored or removed, as the code IMHO has multiple deficiencies:
    22
    33* literal "96f" is repeated many times, sometimes with "f" suffix (float), sometimes without (int)
    … …  
    2020* Adds an indirect dependency to Config for all using classes/tests
    2121
    22 Bottom line:  Before fixing this very broken class, we should probably remove it together with its functionality, as already proposed in https://josm.openstreetmap.de/wiki/Help/HiDPISupport (at the very bottom), and rather fix remaning bugs in the official HiDPI support.
     22Bottom line:  Before fixing this quite broken class, we should probably remove it together with its functionality, as already proposed in https://josm.openstreetmap.de/wiki/Help/HiDPISupport (at the very bottom), and rather fix remaning bugs in the official HiDPI support.
    2323
    2424SCNR I volunteer to get this done.