Opened 6 years ago

Last modified 5 years ago

#19163 closed enhancement

[Patch] unit test updates — at Initial Version

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.06
Component: Core validator Version:
Keywords: template_report unit Cc: Klumbumbus

Description

Please, find attached patch file: josm_validator_numeric_unit_abb.patch
which adds:

  • adds test about long forms of common units and autofixes them to abbreviations: m, ft and t
  • combines the test for separator and the general warning to one for each group instead of one for each tag
  • adds maxaxleload and maxlength to the tests

I was wondering why the regex for width differs compared to the other tags but did not change it, so far:

*[width][width !~ /^(([0-9]+\.?[0-9]*( [a-z]+)?)|([0-9]+\'([0-9]+\.?[0-9]*\")?))$/]

instead of:

*[width][width !~ /^(([0-9]+\.?[0-9]*( (m|ft))?)|([0-9]+\'[0-9]+\.?[0-9]*\"))$/]
Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-25 18:33:44 +0200 (Sat, 25 Apr 2020)
Revision:16382
Build-Date:2020-04-26 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Change History (0)

Note: See TracTickets for help on using tickets.