Use {apikey} everywhere

[Don-vip]

Follow-up of #18440:

• Wait for JOSM users to all run r15855+
• Replace _apiKey_ by {apikey} in Maxar entries
• Remove _apiKey_ support in JMapViewer
• Use {apikey} in all relevant entries:
  • Maps/Worldwide
    • Bing
    • Mapbox
    • mapbox_locator_overlay
    • Maxar-Premium
    • Maxar-Standard Removed
    • opencylemap
    • tf-landscape
    • tf-outdoors
  • Maps/Australia
    • City_of_Melbourne_Feb_2019
    • City_of_Melbourne_May_2018
  • Maps/Austria
    • geoimage.at
  • Maps/Brazil
    • IBGE_DF_Addresses
    • IBGE_Nomes_Ruas
    • IBGE_Salvador_Streets Removed?
  • Maps/New Zealand
    • LINZ_NZ_Aerial_Imagery
    • LINZ_NZ_Topo50_Gridless_Maps
  • Maps/Norway
    • geovekst-nib
  • Maps/Sweden
    • lantmateriet-orto1960
    • lantmateriet-orto1975
    • lantmateriet-topowebb
    • lantmateriet-orto-historic
  • Maps/USA
    • New_and_Misaligned_TIGER_Roads-2013
    • US_Forest_Service_roads_overlay
    • US-TIGER-Roads-2017
    • US-TIGER-Roads-2018
    • US-TIGER-Roads-2019
    • WSDOT-Roads-2017 (2017->2021)
• Update the apikey workaround/support in ELI-Sync-tool

[anonymous]

ELI just addded an {apikey} value to URLs ​https://github.com/osmlab/editor-layer-index/pull/548. For people who use ELI directly in JOSM https://osmlab.github.io/editor-layer-index/imagery.xml this now gives a warning/error.

Is this ticket tracking support for this?

[aharvey]

I was not logged in ^{anonymous message was from me.}

[Don-vip]

Replying to anonyme:

For people who use ELI directly in JOSM

What's the point? JOSM has more entries than ELI, and we check for their validity, so the JOSM dataset is greatly superior both in quantity and quality.

[Stereo]

The workaround if you come across this in JOSM is to upgrade to the latest version. But yeah, like Vincent said, I don't know anyone who uses ELI in JOSM apart from ourselves, the ELI maintainers :).

[stoecker]

Added missing apikeys. Update status.

Last point ELI-tools: getUrlStripped() should be adapted to also handle other apikey places like /token/{apikey} which are now much easier to detect.