Modify

Opened 5 years ago

Closed 5 years ago

#18252 closed defect (invalid)

wikipedia tags with %XX characters not detected by validators

Reported by: pyrog Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. wikipedia=fa:%D8%A2%D8%A8%DB%8C%D8%AF%D8%B1 (node 6856814209)
  2. upload

What is the expected result?

Error or warning message

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

wikipedia=fa:آبیدر

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-10-22 23:54:14 +0200 (Tue, 22 Oct 2019)
Build-Date:2019-10-23 01:30:56
Revision:15470
Relative:URL: ^/trunk

Identification: JOSM/1.5 (15470 fr) Mac OS X 10.14.6
OS Build number: Mac OS X 10.14.6 (18G95)
Memory Usage: 507 MB / 1820 MB (89 MB allocated, but free)
Java version: 1.8.0_221-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: Display 69732928 1280x800
Maximum Screen Size: 1280x800
VM arguments: [-Djava.security.policy=file:<java.home>/lib/security/javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>/bin, -Djava.security.manager, -Djnlpx.origFilenameArg=/Applications/josm-latest.jnlp, -Djnlpx.remove=false, -Dsun.awt.warmup=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=NULL,2048m, -Dmacosx.jnlpx.dock.name=JOSM (development version), -Dmacosx.jnlpx.dock.icon=${HOME}/Library/Application Support/Oracle/Java/Deployment/cache/6.0/25/4c122699-72a21903.icns, -Djnlpx.jvm="<java.home>/bin/java"]
Dataset consistency test: No problems found

Plugins:
+ CADTools (1008)
+ PicLayer (35104)
+ SeaMapEditor (34908)
+ apache-commons (35092)
+ apache-http (34908)
+ cadastre-fr (35194)
+ ejml (35122)
+ geotools (35169)
+ jaxb (35014)
+ jna (34908)
+ jts (35122)
+ opendata (35179)
+ reverter (35084)
+ tag2link (35149)
+ utilsplugin2 (35177)

Tagging presets:
+ https://josm.openstreetmap.de/josmfile?page=Presets/Towers&zip=1
+ https://raw.githubusercontent.com/OpenNauticalChart/josm/master/INT-1-preset.xml
+ https://josm.openstreetmap.de/josmfile?page=Presets/Telecom&zip=1

Validator rules:
+ https://github.com/Jungle-Bus/transport_mapcss/raw/gh-pages/transport.validator.zip

Last errors/warnings:
- E: org.openstreetmap.josm.tools.UncheckedParseException
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=504, Error Header=<timeout. The server is probably too busy to handle your request.>, Error Body=<<?xml version="1.0" encoding="UTF-8"?>
- E: La communication avec le serveur a échoué - ResponseCode=504, Error Header=&lt;timeout. The server is probably too busy to handle your request.&gt;, Error Body=&lt;&lt;?xml version="1.0" encoding="UTF-8"?&gt;
- E: org.openstreetmap.josm.io.OsmApiException: ResponseCode=504, Error Header=<timeout. The server is probably too busy to handle your request.>, Error Body=<<?xml version="1.0" encoding="UTF-8"?>
- E: La communication avec le serveur a échoué - ResponseCode=504, Error Header=&lt;timeout. The server is probably too busy to handle your request.&gt;, Error Body=&lt;&lt;?xml version="1.0" encoding="UTF-8"?&gt;
- E: Handled by bug report queue: java.lang.NullPointerException
- E: Handled by bug report queue: java.lang.NullPointerException
- E: Handled by bug report queue: java.lang.NullPointerException
- E: Handled by bug report queue: java.lang.NullPointerException
- E: Handled by bug report queue: java.lang.NullPointerException

Attachments (0)

Change History (8)

comment:1 by pyrog, 5 years ago

Found new values :

  • wikipedia=ca:Tur%C3%B3 de la Grimola
  • wikipedia=ca:Turó de la Grimola
  • wikipedia=be-tarask:%D0%90%D0%BB%D0%B0 (%D0%93%D0%BE%D0%BC%D0%B5%D0%BB%D1%8C%D1%81%D0%BA%D0%B0%D1%8F %D0%B2%D0%BE%D0%B1%D0%BB%D0%B0%D1%81%D1%8C%D1%86%D1%8C)
  • wikipedia=be-tarask:Ала (Гомельская вобласьць)
  • wikipedia=uk:%D0%9E%D0%BC%D0%B8%D1%82_%28%D0%BE%D0%B7%D0%B5%D1%80%D0%BE%29
  • wikipedia=uk:Омит_(озеро)
  • wikipedia=uk:%D0%92%D0%BE%D0%B4%D1%8F%D0%BD%D0%B0_%D0%BA%D1%83%D0%B7%D0%BD%D1%8F_%D0%93%D0%B0%D0%BC%D0%BE%D1%80%D0%B0
  • wikipedia=uk:Водяна_кузня_Гамора

PS: Wikipedia web server don't like theses values. It display "Bad title"

Version 3, edited 5 years ago by pyrog (previous) (next) (diff)

comment:2 by Klumbumbus, 5 years ago

Component: CoreCore validator

I get a warning "wikipedia tag should not have URL-encoded values like %27"

comment:3 by pyrog, 5 years ago

I save my data, restart JOSM and reload.

I get a warning "wikimedia_commons tag should not have URL-encoded values like %27", but nothing for wikipedia tags.

Are-you using the same version with the same plugins ?

wikipedia=de:Josefslust
wikipedia=en:Raoul Wallenberg Holocaust Memorial Park
wikipedia=https://hu.wikipedia.org/wiki/F%C3%A1jl:Kiss_Couple_stolperstein_(Budapest-07_Kir%C3%A1ly_u_51).jpg
wikipedia=pl:Beskid (Beskid Śląskii)
wikipedia=pl:Beskid Węgierski
wikipedia=pl:Beskidek (Beskid Śląski)
wikipedia=pl:Hyrca
wikipedia=pl:Kiskir%C3%A1lyl%C3%A1ny
wikipedia=sk:Anton%C3%ADn_Benjamin_Svojs%C3%ADk
wikipedia=sk:Cimenn%C3%A1
wikipedia=sk:Hal%C3%A1%C4%8Dovka
wikipedia=sk:Mitick%C3%A1_slatina
wikipedia=sk:Ostr%C3%BD_vrch_(pr%C3%ADrodn%C3%A1_rezerv%C3%A1cia)
wikipedia=sk:Potok_Machn%C3%A1%C4%8D
wikipedia=sk:Svinica_(pr%C3%ADrodn%C3%A1_pamiatka)

For the following tag, I get "Deprecated attributes - The wikipedia tag format is obsolete"…
wikipedia=https://hu.wikipedia.org/wiki/F%C3%A1jl:Kiss Couple stolperstein (Budapest-07 Kir%C3%A1ly u 51).jpg

Last edited 5 years ago by pyrog (previous) (diff)

comment:4 by Klumbumbus, 5 years ago

If you get the warning "wikimedia_commons tag should..." you should get the warning "wikipedia tag should..." too, becasue both rules are in the same internal file: https://josm.openstreetmap.de/browser/josm/trunk/data/validator/wikipedia.mapcss#L42
Please check your validator ignore list.

comment:5 by pyrog, 5 years ago

How ? Where is this list ?

comment:6 by Klumbumbus, 5 years ago

In the validator panel on the right, the button "Manage ignore".

comment:7 by pyrog, 5 years ago

Bingo :)

Thank you very much.

I didn't know this button, and thought that ignore was valid only for the current JOSM "session".
(The list will be reset at the next restart)

comment:8 by Klumbumbus, 5 years ago

Resolution: invalid
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.