Changes between Initial Version and Version 10 of Ticket #18244


Ignore:
Timestamp:
2019-10-22T00:30:56+02:00 (6 years ago)
Author:
Don-vip
Comment:

OK so there's only one problem, the missing save warning for layers with upload=never

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18244

    • Property Keywords save upload added
    • Property Summary No warning on closing unsaved edits in layers loaded from fileNo warning on closing unsaved edits in layers with upload=never flag
    • Property Type enhancementdefect
  • Ticket #18244 – Description

    initial v10  
    11First the use case: In Switzerland we can use GWR address data. Simon Poole has preprocessed files with these data: [http://qa.poole.ch/addresses/ch/]. If you download an {{{.osm}}} file (link 'O', unpack zip) you can load such a file as a separate layer. Now I copy and delete an address from that layer, switch to the data layer and past the address to the building.
    22
    3 I got two problems with layers loaded from file. The first is more for completeness:
     3~~I got two problems with layers loaded from file. The first is more for completeness: ~~
    44If I only load the GWR.osm file and change something, the {{{File.Save}}} menu will be enabled (ok), but when I close the modified layer in the Layers view, it is closed without and warning. But I would expect a warning that I'm about to loose edits.
    55
    6 The second problem is much more annoying:
    7 Download an area into a data layer. Additionally load the GWR.osm file. Edit on both layers. If I now activate the GWR data layer and go to the file menu, {{{Save}}} is disabled! You could save the data with {{{Save as...}}} and hopefully choose the right file to override. The changes are recognized: choose {{{Info}}} about the GWR data layer and you will see your edits in that layer. After uploading the data (from the data layer), the edits in the GWR data file are still not saved, {{{Save}}} is disabled and the edits got lost without warning on closing the layer or JOSM.
     6~~The second problem is much more annoying:
     7Download an area into a data layer. Additionally load the GWR.osm file. Edit on both layers. If I now activate the GWR data layer and go to the file menu, {{{Save}}} is disabled! You could save the data with {{{Save as...}}} and hopefully choose the right file to override. The changes are recognized: choose {{{Info}}} about the GWR data layer and you will see your edits in that layer. After uploading the data (from the data layer), the edits in the GWR data file are still not saved, {{{Save}}} is disabled and the edits got lost without warning on closing the layer or JOSM.~~
    88
    99Perhaps this has to do with {{{upload='never'}}} flag in the {{{.osm}}} file.
    1010
    11 But I would expect, that at least {{{File.Save}}} is enabled for this layer and that I got a warning about unsaved data on deleting the layer or leaving JOSM.
     11But I would expect, that ~~at least {{{File.Save}}} is enabled for this layer and that~~ I got a warning about unsaved data on deleting the layer or leaving JOSM.