Changes between Initial Version and Version 1 of Ticket #18133, comment 6


Ignore:
Timestamp:
2020-01-26T11:03:00+01:00 (6 years ago)
Author:
GerdP

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18133, comment 6

    initial v1  
    1 Some code issues:
    2 - "Strings literals should be placed on the left side when checking for equality", so use `"route".equals(type)` instead of `type.equals("route")` 
    3 - the unit tests have no javadoc, see e.g. `OsmValidatorTest.testCleanupIgnoredErrorsTicket17837()`. In `HighwaysTest.testTicket14891()` you can find an example that uses an *.osm file  as input. This makes it easier to understand what the test is about as you can also load the test data into JOSM.
    4 - please use ant checkstyle pmd and fix the reported problems before providing a patch