Changes between Initial Version and Version 1 of Ticket #18126, comment 12


Ignore:
Timestamp:
2019-09-19T21:59:26+02:00 (6 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #18126, comment 12

    initial v1  
    1616* `ant pmd checkstyle` didn't throw any warnings (which is a good thing -- on one of my machines, I cannot run it, and I have to rely on style enforcement in Eclipse, which can be hit or miss).
    1717* You should have tests that verify the correctness of the output. It may perform correctly now, but if someone refactors it for speed/readability/code deduplication, then it might not perform correctly. It might not error out, but still return erroneous results. Some people (like me) assume that the original test writer wrote the tests checking for accurate output.
     18[EDIT: I probably should have added that I knew you had mentioned that you hadn't added any unit tests]
    1819
    1920Replying to [comment:11 francians]: