Changes between Initial Version and Version 1 of Ticket #17177, comment 17


Ignore:
Timestamp:
2021-03-23T17:28:38+01:00 (5 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17177, comment 17

    initial v1  
    22* pbf/mapillary/14/3251/6258.mvt (`ProtoBufTest#testRead_14_3251_6258`)
    33* pbf/openinframap/17/26028/50060.pbf (`ProtoBufTest#testRead_17_26028_50060`)
     4
     5Additional notes:
     6There are three TODOs remaining in attachment:17177.7.protobuf.patch
     7
     8Two are the same (`ProtoBufRecord#asFixed{32,64}`), and has to do with what should happen if the actual wiretype isn't the appropriate type. I'm inclined to throw an exception, but feedback would be appreciated on that.
     9
     10The last is for `ProtoBufParser#convertLong`, and has to do with booleans. The specification for protobuf buffers indicates that booleans (and enums) are of the VarInt type, and I'm inclined to treat booleans like I'm treating enums, and let the consumer convert the number to a boolean.