Changes between Version 1 and Version 2 of Ticket #17131, comment 2


Ignore:
Timestamp:
2018-12-21T16:28:55+01:00 (7 years ago)
Author:
taylor.smock

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #17131, comment 2

    v1 v2  
    33As far as `org.openstreetmap.josm.tools.Geometry`, I didn't see any `distance` methods in it. I should probably look at moving many (or all) of the methods in GpxDistance to Geometry.
    44
    5 As far as `ant pmd checkstyle` goes, I couldn't run it. This is probably due to a hardcoded path somewhere in build.xml for ant. I fixed it with `ln -s "$(which ant)" /usr/local/share/ant`.
     5As far as `ant pmd checkstyle` goes, I couldn't run it. This is probably due to a hardcoded path somewhere in build.xml for ant. I fixed it with `ln -s "$(which ant)" /usr/local/share/ant`, and the patch no longer has warnings from it.
    66{{{
    77iMacs-iMac-6:core tsmock$ ant pmd checkstyle
    … …  
    1919Incremental analysis can't check execution classpath contents
    2020java.nio.file.NoSuchFileException: /usr/local/share/ant
    21         at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
    22         at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
    23         at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
    24         at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
    25         at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:145)
    26         at java.base/java.nio.file.Files.readAttributes(Files.java:1763)
    27         at java.base/java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:225)
    28         at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:276)
    29         at java.base/java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:322)
    30         at java.base/java.nio.file.Files.walkFileTree(Files.java:2716)
    31         at net.sourceforge.pmd.cache.AbstractAnalysisCache.getClassPathEntries(AbstractAnalysisCache.java:159)
    32         at net.sourceforge.pmd.cache.AbstractAnalysisCache.checkValidity(AbstractAnalysisCache.java:130)
    33         at net.sourceforge.pmd.processor.AbstractPMDProcessor.processFiles(AbstractPMDProcessor.java:102)
    34         at net.sourceforge.pmd.PMD.processFiles(PMD.java:329)
    35         at net.sourceforge.pmd.ant.internal.PMDTaskImpl.doTask(PMDTaskImpl.java:191)
    36         at net.sourceforge.pmd.ant.internal.PMDTaskImpl.execute(PMDTaskImpl.java:275)
    37         at net.sourceforge.pmd.ant.PMDTask.execute(PMDTask.java:50)
    38         at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
    39         at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    40         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    41         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    42         at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
    43         at org.apache.tools.ant.Task.perform(Task.java:350)
    44         at org.apache.tools.ant.Target.execute(Target.java:449)
    45         at org.apache.tools.ant.Target.performTasks(Target.java:470)
    46         at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
    47         at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
    48         at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
    49         at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
    50         at org.apache.tools.ant.Main.runBuild(Main.java:834)
    51         at org.apache.tools.ant.Main.startAnt(Main.java:223)
    52         at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
    53         at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
    54       [pmd] java.lang.RuntimeException: java.nio.file.NoSuchFileException: /usr/local/share/ant
    55       [pmd]     at net.sourceforge.pmd.cache.AbstractAnalysisCache.getClassPathEntries(AbstractAnalysisCache.java:174)
    56       [pmd]     at net.sourceforge.pmd.cache.AbstractAnalysisCache.checkValidity(AbstractAnalysisCache.java:130)
    57       [pmd]     at net.sourceforge.pmd.processor.AbstractPMDProcessor.processFiles(AbstractPMDProcessor.java:102)
    58       [pmd]     at net.sourceforge.pmd.PMD.processFiles(PMD.java:329)
    59       [pmd]     at net.sourceforge.pmd.ant.internal.PMDTaskImpl.doTask(PMDTaskImpl.java:191)
    60       [pmd]     at net.sourceforge.pmd.ant.internal.PMDTaskImpl.execute(PMDTaskImpl.java:275)
    61       [pmd]     at net.sourceforge.pmd.ant.PMDTask.execute(PMDTask.java:50)
    62       [pmd]     at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
    63       [pmd]     at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    64       [pmd]     at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    65       [pmd]     at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    66       [pmd]     at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
    67       [pmd]     at org.apache.tools.ant.Task.perform(Task.java:350)
    68       [pmd]     at org.apache.tools.ant.Target.execute(Target.java:449)
    69       [pmd]     at org.apache.tools.ant.Target.performTasks(Target.java:470)
    70       [pmd]     at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
    71       [pmd]     at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
    72       [pmd]     at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
    73       [pmd]     at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
    74       [pmd]     at org.apache.tools.ant.Main.runBuild(Main.java:834)
    75       [pmd]     at org.apache.tools.ant.Main.startAnt(Main.java:223)
    76       [pmd]     at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
    77       [pmd]     at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
    78       [pmd] Caused by: java.nio.file.NoSuchFileException: /usr/local/share/ant
    79       [pmd]     at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
    80       [pmd]     at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
    81       [pmd]     at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
    82       [pmd]     at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
    83       [pmd]     at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:145)
    84       [pmd]     at java.base/java.nio.file.Files.readAttributes(Files.java:1763)
    85       [pmd]     at java.base/java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:225)
    86       [pmd]     at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:276)
    87       [pmd]     at java.base/java.nio.file.FileTreeWalker.walk(FileTreeWalker.java:322)
    88       [pmd]     at java.base/java.nio.file.Files.walkFileTree(Files.java:2716)
    89       [pmd]     at net.sourceforge.pmd.cache.AbstractAnalysisCache.getClassPathEntries(AbstractAnalysisCache.java:159)
    90       [pmd]     ... 22 more
    91       [pmd] null        -       java.nio.file.NoSuchFileException: /usr/local/share/ant
    92 
    93 BUILD FAILED
    94 /Users/tsmock/workspace/josm/core/build.xml:943: java.lang.NullPointerException
    95         at net.sourceforge.pmd.util.StringUtil.appendXmlEscaped(StringUtil.java:214)
    96         at net.sourceforge.pmd.renderers.XMLRenderer.end(XMLRenderer.java:124)
    97         at net.sourceforge.pmd.ant.Formatter.end(Formatter.java:117)
    98         at net.sourceforge.pmd.ant.internal.PMDTaskImpl.doTask(PMDTaskImpl.java:201)
    99         at net.sourceforge.pmd.ant.internal.PMDTaskImpl.execute(PMDTaskImpl.java:275)
    100         at net.sourceforge.pmd.ant.PMDTask.execute(PMDTask.java:50)
    101         at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
    102         at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    103         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    104         at java.base/java.lang.reflect.Method.invoke(Method.java:566)
    105         at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
    106         at org.apache.tools.ant.Task.perform(Task.java:350)
    107         at org.apache.tools.ant.Target.execute(Target.java:449)
    108         at org.apache.tools.ant.Target.performTasks(Target.java:470)
    109         at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1388)
    110         at org.apache.tools.ant.Project.executeTarget(Project.java:1361)
    111         at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
    112         at org.apache.tools.ant.Project.executeTargets(Project.java:1251)
    113         at org.apache.tools.ant.Main.runBuild(Main.java:834)
    114         at org.apache.tools.ant.Main.startAnt(Main.java:223)
    115         at org.apache.tools.ant.launch.Launcher.run(Launcher.java:284)
    116         at org.apache.tools.ant.launch.Launcher.main(Launcher.java:101)
    117 
    118 Total time: 1 second
     21<TRIMMED>
    11922}}}
    12023{{{