Changes between Initial Version and Version 1 of Ticket #16995, comment 18


Ignore:
Timestamp:
2018-11-23T11:03:16+01:00 (7 years ago)
Author:
cmuelle8

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16995, comment 18

    initial v1  
    33Leaving that data type to be disambiguous may seem convenient when instantiating/writing {{{WayPoint}}} objects, but is less so when using/reading them:  That ternary operator currently living in {{{setTimeFromAttribute}}} basically cries out to be copied to each and every place that the attribute is used/read  (unless you have a unit test that only tests half of the possibilties).
    44
     5
     6EDIT:  Code broken after this should be fixable by associating {{{DateUtils.fromString(obj.toString())}}} instead of {{{obj}}} with {{{GpxConstants.PT_TIME}}} attributes.  (It basically means moving the functionality of that ternary operator out of {{{WayPoint}}} to those clients that generate objects of it.)