Changes between Initial Version and Version 1 of Ticket #16982


Ignore:
Timestamp:
2018-11-11T15:05:58+01:00 (7 years ago)
Author:
Don-vip
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #16982 – Description

    initial v1  
    99I've noticed that this constructor is executed thousands of times:
    1010{{{
     11#!java
    1112    public MapCSSTagChecker() {
    1213        super(tr("Tag checker (MapCSS based)"), tr("This test checks for errors in tag keys and values."));
    … …  
    1516The reason is this code line:
    1617 {{{
     18#!java
    1719final TestError error = check.getErrorForPrimitive(p, selector, env, new MapCSSTagCheckerAndRule(check.rule));
    1820}}}
    1921which is executed for many nodes because of rules like this
    2022{{{
     23#!mapcss
    2124way[highway][area!=yes][!tunnel][!covered] > node {
    2225  set node_in_highway;
    2326}
     27}}}
    2428The attached mini patch avoids this by checking first if check.errors is empty.
    25 }}}
    2629{{{
    2730Build-Date:2018-11-11 09:58:32